You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "davecromberge (via GitHub)" <gi...@apache.org> on 2023/06/09 12:10:49 UTC
[GitHub] [pinot] davecromberge opened a new pull request, #10878: Upgrade to Apache Datasketches 4.0.0
davecromberge opened a new pull request, #10878:
URL: https://github.com/apache/pinot/pull/10878
Upgrade to Apache Datasketches 4.0.0
The 4.0.0 release incorporates some of the following changes that are relevant to implementations within Pinot:
- API changes within Quantile Sketches, including the "SortedView" which is iterable and makes analysis of the quantile distribution even easier.
- Theta Sketches have been enhanced with an optional compress operation that makes the serialized theta sketch smaller.
Note that Theta compression is not yet enabled as this would require all clients using raw sketches to be upgraded. Although the Pinot codebase uses the ClearSpring HLL sketch, the Datasketches 4.0.0 release includes major speed improvements to the Apache Datasketches HLL implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] cbalci commented on pull request #10878: Upgrade to Apache Datasketches 4.0.0
Posted by "cbalci (via GitHub)" <gi...@apache.org>.
cbalci commented on PR #10878:
URL: https://github.com/apache/pinot/pull/10878#issuecomment-1585444464
LGTM, thanks for the upgrade David. π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10878: Upgrade to Apache Datasketches 4.0.0
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10878:
URL: https://github.com/apache/pinot/pull/10878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10878: Upgrade to Apache Datasketches 4.0.0
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10878:
URL: https://github.com/apache/pinot/pull/10878#issuecomment-1584541300
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10878](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b0f4c25) into [master](https://app.codecov.io/gh/apache/pinot/commit/a75544f2c644874a88b61cea48b640d9cf05283c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a75544f) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10878 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2186 2132 -54
Lines 117353 114850 -2503
Branches 17730 17428 -302
=========================================
Hits 137 137
+ Misses 117196 114693 -2503
Partials 20 20
```
| Flag | Coverage Ξ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `0.00% <0.00%> (ΓΈ)` | |
| unittests2temurin11 | `0.11% <0.00%> (ΓΈ)` | |
| unittests2temurin17 | `0.11% <0.00%> (ΓΈ)` | |
| unittests2temurin20 | `0.11% <0.00%> (ΓΈ)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [...AvgValueIntegerTupleSketchAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BdmdWYWx1ZUludGVnZXJUdXBsZVNrZXRjaEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ΓΈ)` | |
| [...n/DistinctCountThetaSketchAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50VGhldGFTa2V0Y2hBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | |
| [...umValuesIntegerTupleSketchAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/10878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9TdW1WYWx1ZXNJbnRlZ2VyVHVwbGVTa2V0Y2hBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ΓΈ)` | |
... and [54 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10878/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Weβre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org