You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/22 18:18:56 UTC
[GitHub] jmeter pull request #337: Tidy JavaDoc and fix error in getTop5ErrorMetrics ...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/337
Tidy JavaDoc and fix error in getTop5ErrorMetrics method.
## Description
Fixed bug whereby calling `registerError` with the following data set `["A", "B", "C", "D", "E", "F"]` would return `[["A", 1], [null, null], [null, null], [null, null], [null, null]]` instead of `[["A", 1], ["B", 1], ["C", 1], ["D", 1], ["E", 1]]`.
Improved JavaDoc for `registerError`
Also removed JavaDoc which did not add anything to the method names.
## Motivation and Context
Made the code more readable and at the same time fixed a subtle error.
## How Has This Been Tested?
On my spock branch:
```groovy
def "errors with the same frequency are preserved up until the size limit"() {
given:
def testData = ["A", "B", "C", "D", "E", "F"]
for (def key : testData) {
sut.registerError(key)
}
expect:
sut.getTop5ErrorsMetrics() == [["A", 1], ["B", 1], ["C", 1], ["D", 1], ["E", 1]]
}
```
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter top_5_error_bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/337.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #337
----
commit 762b0fe5919e8aa75f1d21abb3fdaf7292a8d049
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-22T18:03:14Z
Tidy JavaDoc and fix error in getTop5ErrorMetrics method.
----
---
[GitHub] jmeter pull request #337: Tidy JavaDoc and fix error in getTop5ErrorMetrics ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/337
---
[GitHub] jmeter issue #337: Tidy JavaDoc and fix error in getTop5ErrorMetrics method.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/337
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=h1) Report
> Merging [#337](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/82afa3fa49071e7e92397975089d160529147fea?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #337 +/- ##
============================================
+ Coverage 57.91% 57.92% +0.01%
- Complexity 10022 10024 +2
============================================
Files 1148 1148
Lines 73785 73779 -6
Branches 7328 7326 -2
============================================
+ Hits 42730 42735 +5
+ Misses 28578 28567 -11
Partials 2477 2477
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...jmeter/report/processor/Top5ErrorsSummaryData.java](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L3Byb2Nlc3Nvci9Ub3A1RXJyb3JzU3VtbWFyeURhdGEuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `86.15% <0%> (+0.76%)` | `19% <0%> (+1%)` | :arrow_up: |
| [...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `30.95% <0%> (+3.17%)` | `11% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=footer). Last update [82afa3f...7e3d23f](https://codecov.io/gh/apache/jmeter/pull/337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---