You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by pc...@hyperreal.org on 1999/02/05 10:14:57 UTC

cvs commit: apache-1.3/src/include httpd.h

pcs         99/02/05 01:14:57

  Modified:    src/include httpd.h
  Log:
  On most platforms, the default name of the error and access logs is the
  same as the values on the ErrorLog and CustomerLog lines in the
  distributed httpd.conf file. For example, on OS/2 the logs are defined as
  error.log and access.log. But on Windows, they are still error_log and
  access_log in the program.  This doesn't match the "default" as documented
  or as given in the distributed httpd.conf.
  
  Reviewed by:	Brian Behlendorf
  
  Revision  Changes    Path
  1.266     +2 -4      apache-1.3/src/include/httpd.h
  
  Index: httpd.h
  ===================================================================
  RCS file: /export/home/cvs/apache-1.3/src/include/httpd.h,v
  retrieving revision 1.265
  retrieving revision 1.266
  diff -u -r1.265 -r1.266
  --- httpd.h	1999/01/27 12:16:00	1.265
  +++ httpd.h	1999/02/05 09:14:56	1.266
  @@ -151,8 +151,7 @@
   
   /* The name of the log files */
   #ifndef DEFAULT_XFERLOG
  -#ifdef OS2
  -/* Set default for OS/2 file system */
  +#if defined(OS2) || defined(WIN32)
   #define DEFAULT_XFERLOG "logs/access.log"
   #else
   #define DEFAULT_XFERLOG "logs/access_log"
  @@ -160,8 +159,7 @@
   #endif /* DEFAULT_XFERLOG */
   
   #ifndef DEFAULT_ERRORLOG
  -#ifdef OS2
  -/* Set default for OS/2 file system */
  +#if defined(OS2) || defined(WIN32)
   #define DEFAULT_ERRORLOG "logs/error.log"
   #else
   #define DEFAULT_ERRORLOG "logs/error_log"
  
  
  

default acccess log

Posted by Paul Sutton <pa...@awe.com>.
On 5 Feb 1999 pcs@hyperreal.org wrote:
>    /* The name of the log files */
>    #ifndef DEFAULT_XFERLOG
>   -#ifdef OS2
>   -/* Set default for OS/2 file system */
>   +#if defined(OS2) || defined(WIN32)
>    #define DEFAULT_XFERLOG "logs/access.log"
>    #else
>    #define DEFAULT_XFERLOG "logs/access_log"

Actually, there is no point setting a default xfer log at all, is there,
since no if CustomLog/TransferLog is given no access log is produced.

The code which sets and displays the "default" access log needs removing.
Oh, except I guess there may be alternate logging modules which expect
a DEFAULT_XFERLOG macro.

Paul