You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gotama (JIRA)" <ji...@codehaus.org> on 2008/08/13 23:42:26 UTC

[jira] Created: (MASSEMBLY-346) DependencySets Includes/Excludes Do Not Work Correctly And Type Is Ignored

DependencySets Includes/Excludes Do Not Work Correctly And Type Is Ignored
--------------------------------------------------------------------------

                 Key: MASSEMBLY-346
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-346
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2-beta-2
         Environment: Win2003/Cygwin Maven 2.0.8

            Reporter: gotama



There are a lot of things wrong with includes/excludes and types in DependencySets. Basically, it needs to be completely regression tested as it completely does not work right in many ways.

group:artifact:type

In describing type, its ignored. When I put zip for type, I can get ear files. When I exclude all com.* artifacts then include my own com.mydotcom.* - I actually get double the ears in my resulting zip artifact. Example below:

 <dependencySets>
        <dependencySet>
            <outputDirectory>/opt/jboss/server/default/deploy/</outputDirectory>
            <excludes>
                <exclude>com:*</exclude>
            </excludes>
        </dependencySet>
        <dependencySet>
            <outputDirectory>/opt/jboss/server/default/deploy/</outputDirectory>
            <includes>
                <include>com.mydotcom:*:ear</include>
            </includes>
        </dependencySet>
    </dependencySets>


In general, there seems to be issue with the wild card. Putting com.mydotcom:*:zip - once the * is hit, everything after it is ignored. However, for <include> putting com:*:zip does work correctly - oddly enough. It correctly does NOT give me ear files. When I put com:*:ear I correctly get ears. When I put com.mydotcom:*:zip, then I incorrectly get all ears. Lots of inconsistencies here and odd behavior.

Here is a good document on includes/excludes. Unfortunately, this does not work right. I'd suggest excludes/includes be completely re-looked at. Thanks!!!

http://www.sonatype.com/book/reference/assemblies.html#d0e13207


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-346) DependencySets Includes/Excludes Do Not Work Correctly And Type Is Ignored

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MASSEMBLY-346.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2-beta-6
         Assignee: John Casey

if you find this is still broken - despite our tests - then please submit a sample project using the latest release of the plugin that expresses the problem.

> DependencySets Includes/Excludes Do Not Work Correctly And Type Is Ignored
> --------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-346
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-346
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>         Environment: Win2003/Cygwin Maven 2.0.8
>            Reporter: gotama
>            Assignee: John Casey
>             Fix For: 2.2-beta-6
>
>
> There are a lot of things wrong with includes/excludes and types in DependencySets. Basically, it needs to be completely regression tested as it completely does not work right in many ways.
> group:artifact:type
> In describing type, its ignored. When I put zip for type, I can get ear files. When I exclude all com.* artifacts then include my own com.mydotcom.* - I actually get double the ears in my resulting zip artifact. Example below:
>  <dependencySets>
>         <dependencySet>
>             <outputDirectory>/opt/jboss/server/default/deploy/</outputDirectory>
>             <excludes>
>                 <exclude>com:*</exclude>
>             </excludes>
>         </dependencySet>
>         <dependencySet>
>             <outputDirectory>/opt/jboss/server/default/deploy/</outputDirectory>
>             <includes>
>                 <include>com.mydotcom:*:ear</include>
>             </includes>
>         </dependencySet>
>     </dependencySets>
> In general, there seems to be issue with the wild card. Putting com.mydotcom:*:zip - once the * is hit, everything after it is ignored. However, for <include> putting com:*:zip does work correctly - oddly enough. It correctly does NOT give me ear files. When I put com:*:ear I correctly get ears. When I put com.mydotcom:*:zip, then I incorrectly get all ears. Lots of inconsistencies here and odd behavior.
> Here is a good document on includes/excludes. Unfortunately, this does not work right. I'd suggest excludes/includes be completely re-looked at. Thanks!!!
> http://www.sonatype.com/book/reference/assemblies.html#d0e13207

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira