[I] UpdateSchema: delete column validation checks children's updates instead of the column's own updates [iceberg-go]

["badalprasadsingh (via GitHub)" <gi...@apache.org>]

badalprasadsingh opened a new issue, #1778:
URL: https://github.com/apache/iceberg-go/issues/1778

   ### Apache Iceberg version
   
   main (development)
   
   ### Please describe the bug 🐞
   
   In Update Schema, `deleteColumn` function guards against deleting a column that has a pending update with 
   ```go
   if _, ok := u.updates[field.ID]; ok
   ```
   
   However, `u.updates` is a `map[int]map[int]iceberg.NestedField` keyed by `[parentID][fieldID]`, so `u.updates[field.ID]` inspects updates staged for the field's children, not the field itself.
   
   Because of this, 
   - Deleting a col that has its own pending update (e.g., a rename, type or doc change) is wrongly **allowed**, silently discarding the staged update - _ideally, we should reject it_
   - Deleting a struct whose child was updated is wrongly **rejected** with a misleading "field that has updates cannot be deleted" error, even though the struct itself has no updates
   
   ### Contribution
   
   We raise a PR for this fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] UpdateSchema: delete column validation checks children's updates instead of the column's own updates [iceberg-go]

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade closed issue #1778: UpdateSchema: delete column validation checks children's updates instead of the column's own updates
URL: https://github.com/apache/iceberg-go/issues/1778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org