You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2016/01/27 02:40:22 UTC
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/10937
[SPARK-12938][SQL] DataFrame API for Bloom filter
This PR integrates Bloom filter from spark-sketch into DataFrame. This version resorts to RDD.aggregate for building the filter. A more performant UDAF version can be built in future follow-up PRs.
This PR also add 2 specify `put` version(`putBinary` and `putLong`) into `BloomFilter`, which makes it easier to build a Bloom filter over a `DataFrame`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark bloom-filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10937
----
commit 139e56f9504e54d93726a12c5c87b28dd03a35fb
Author: Wenchen Fan <we...@databricks.com>
Date: 2016-01-26T20:36:06Z
DataFrame API for Bloom filter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r51028055
--- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java ---
@@ -124,13 +161,11 @@ public boolean put(Object item) {
return bitsChanged;
}
- @Override
- public boolean mightContain(Object item) {
- long bitSize = bits.bitSize();
- long hash64 = hashObjectToLong(item);
- int h1 = (int) (hash64 >> 32);
- int h2 = (int) hash64;
+ private boolean mightContainLong(long l) {
--- End diff --
we should open this one as an api too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175804327
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175812683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50211/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175812681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r50942377
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -309,4 +312,77 @@ final class DataFrameStatFunctions private[sql](df: DataFrame) {
def sampleBy[T](col: String, fractions: ju.Map[T, jl.Double], seed: Long): DataFrame = {
sampleBy(col, fractions.asScala.toMap.asInstanceOf[Map[T, Double]], seed)
}
+
+ /**
+ * Builds a Bloom filter over a specified column.
+ *
+ * @param colName name of the column over which the filter is built
+ * @param expectedNumItems expected number of items which will be put into the filter.
+ * @param fpp expected false positive probability of the filter.
+ *
+ * @since 2.0.0
+ */
+ def bloomFilter(colName: String, expectedNumItems: Long, fpp: Double): BloomFilter = {
+ buildBloomFilter(Column(colName), BloomFilter.create(expectedNumItems, fpp))
+ }
+
+ /**
+ * Builds a Bloom filter over a specified column.
+ *
+ * @param col the column over which the filter is built
+ * @param expectedNumItems expected number of items which will be put into the filter.
+ * @param fpp expected false positive probability of the filter.
+ *
+ * @since 2.0.0
+ */
+ def bloomFilter(col: Column, expectedNumItems: Long, fpp: Double): BloomFilter = {
+ buildBloomFilter(col, BloomFilter.create(expectedNumItems, fpp))
+ }
+
+ /**
+ * Builds a Bloom filter over a specified column.
+ *
+ * @param colName name of the column over which the filter is built
+ * @param expectedNumItems expected number of items which will be put into the filter.
+ * @param numBits expected number of bits of the filter.
+ *
+ * @since 2.0.0
+ */
+ def bloomFilter(colName: String, expectedNumItems: Long, numBits: Long): BloomFilter = {
+ buildBloomFilter(Column(colName), BloomFilter.create(expectedNumItems, numBits))
+ }
+
+ /**
+ * Builds a Bloom filter over a specified column.
+ *
+ * @param col the column over which the filter is built
+ * @param expectedNumItems expected number of items which will be put into the filter.
+ * @param numBits expected number of bits of the filter.
+ *
+ * @since 2.0.0
+ */
+ def bloomFilter(col: Column, expectedNumItems: Long, numBits: Long): BloomFilter = {
+ buildBloomFilter(col, BloomFilter.create(expectedNumItems, numBits))
+ }
+
+ private def buildBloomFilter(col: Column, zero: BloomFilter): BloomFilter = {
+ val singleCol = df.select(col)
+ val colType = singleCol.schema.head.dataType
+
+ require(colType == StringType || colType.isInstanceOf[IntegralType],
+ s"Bloom filter only supports string type and integral types, but got $colType.")
+
+ val seqOp: (BloomFilter, InternalRow) => BloomFilter = if (colType == StringType) {
+ (filter, row) =>
+ filter.putBinary(row.getUTF8String(0).getBytes)
+ filter
--- End diff --
Also add comment to explain the branching at here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175864364
Thanks - going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175862720
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50208/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175804984
**[Test build #50208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50208/consoleFull)** for PR 10937 at commit [`bd0671c`](https://github.com/apache/spark/commit/bd0671ca177457d5f433c2744ed82c7e4960c965).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r51028099
--- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java ---
@@ -124,13 +161,11 @@ public boolean put(Object item) {
return bitsChanged;
}
- @Override
- public boolean mightContain(Object item) {
- long bitSize = bits.bitSize();
- long hash64 = hashObjectToLong(item);
- int h1 = (int) (hash64 >> 32);
- int h2 = (int) hash64;
+ private boolean mightContainLong(long l) {
--- End diff --
(can you guys also fix count-min sketch to make them consistent?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175334264
cc @rxin @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175786530
Since the two (cms and bf) are implemented by two different persons, it'd be great for one of you to go through both to make sure everything is consistent. We can do that in a follow-up pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175379511
**[Test build #50156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50156/consoleFull)** for PR 10937 at commit [`a0dcaa8`](https://github.com/apache/spark/commit/a0dcaa8a52dcda16abccc93d3b63c251e60da3a3).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class BloomFilterImpl extends BloomFilter implements Serializable `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r51028072
--- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java ---
@@ -124,13 +161,11 @@ public boolean put(Object item) {
return bitsChanged;
}
- @Override
- public boolean mightContain(Object item) {
- long bitSize = bits.bitSize();
- long hash64 = hashObjectToLong(item);
- int h1 = (int) (hash64 >> 32);
- int h2 = (int) hash64;
+ private boolean mightContainLong(long l) {
--- End diff --
and have a mightContain for string as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175861576
**[Test build #50208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50208/consoleFull)** for PR 10937 at commit [`bd0671c`](https://github.com/apache/spark/commit/bd0671ca177457d5f433c2744ed82c7e4960c965).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class Utils `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r51027925
--- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java ---
@@ -63,55 +65,90 @@ public long bitSize() {
return bits.bitSize();
}
- private static long hashObjectToLong(Object item) {
- if (item instanceof String) {
- try {
- byte[] bytes = ((String) item).getBytes("utf-8");
- return hashBytesToLong(bytes);
- } catch (UnsupportedEncodingException e) {
- throw new RuntimeException("Only support utf-8 string", e);
- }
+ private byte[] getBytesFromUTF8String(Object s) {
+ try {
+ return ((String) s).getBytes("utf-8");
+ } catch (UnsupportedEncodingException e) {
+ throw new RuntimeException("Only support utf-8 string", e);
+ }
+ }
+
+ private long integralToLong(Object i) {
+ long longValue;
+
+ if (i instanceof Long) {
+ longValue = (Long) i;
+ } else if (i instanceof Integer) {
+ longValue = ((Integer) i).longValue();
+ } else if (i instanceof Short) {
+ longValue = ((Short) i).longValue();
+ } else if (i instanceof Byte) {
+ longValue = ((Byte) i).longValue();
} else {
- long longValue;
-
- if (item instanceof Long) {
- longValue = (Long) item;
- } else if (item instanceof Integer) {
- longValue = ((Integer) item).longValue();
- } else if (item instanceof Short) {
- longValue = ((Short) item).longValue();
- } else if (item instanceof Byte) {
- longValue = ((Byte) item).longValue();
- } else {
- throw new IllegalArgumentException(
- "Support for " + item.getClass().getName() + " not implemented"
- );
- }
+ throw new IllegalArgumentException(
+ "Support for " + i.getClass().getName() + " not implemented"
--- End diff --
"Unsupported data type " + i.getClass().getName()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175803313
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175862713
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175379618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50156/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175341068
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175336514
**[Test build #50156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50156/consoleFull)** for PR 10937 at commit [`a0dcaa8`](https://github.com/apache/spark/commit/a0dcaa8a52dcda16abccc93d3b63c251e60da3a3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175803315
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50207/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175379617
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10937#discussion_r51027480
--- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java ---
@@ -96,6 +96,16 @@ int getVersionNumber() {
public abstract boolean put(Object item);
/**
+ * A specific version of {@link #put(Object)}, that can only be used to put byte array.
--- End diff --
specific -> specialized
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12938][SQL] DataFrame API for Bloom fil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10937#issuecomment-175341072
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50153/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org