You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Xintong Song (Jira)" <ji...@apache.org> on 2022/12/21 07:07:00 UTC
[jira] [Closed] (FLINK-30409) Support reopening closed metric groups
[ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xintong Song closed FLINK-30409.
--------------------------------
Fix Version/s: 1.17.0
Resolution: Done
master (1.17): 535f02c72f3dfdedd4f40a30cc27364a5f5c2cdf
> Support reopening closed metric groups
> --------------------------------------
>
> Key: FLINK-30409
> URL: https://issues.apache.org/jira/browse/FLINK-30409
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Affects Versions: 1.17.0
> Reporter: Mason Chen
> Assignee: Mason Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.17.0
>
>
> Currently, metricGroup.close() will unregister metrics and the underlying metric groups. If the metricGroup is created again via addGroup(), it will silently fail to create metrics since the metric group is in a closed state.
> We need to close metric groups and reopen them because some of the metrics may reference old objects that are no longer relevant/stale and we need to re-create the metric/metric group to point to the new references. For example, we may close `KafkaSourceReader` to remove a topic partition from assignment and then recreate `KafkaSourceReader` with a different set of topic partitions. The metrics should also reflect that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)