You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/13 21:06:15 UTC

[GitHub] [pulsar] kellyfj opened a new pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values 

kellyfj opened a new pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052


   ### Motivation
   Make the test code a little more readable and maintainable and clarify intent of `Thread.sleep(3000)` 
   
   ### Modifications
   Refactored Thread.sleep() to common function and hard-coded Http values to constants
   
   ### Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052#issuecomment-692422240


   Please rebase to the latest master. There have some fixes about the CI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052#issuecomment-722055537


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052#issuecomment-701919276


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] kellyfj commented on pull request #8052: [Broker] Improve test code readability and maintainability by refactoring repeated values

Posted by GitBox <gi...@apache.org>.
kellyfj commented on pull request #8052:
URL: https://github.com/apache/pulsar/pull/8052#issuecomment-701334261


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org