You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/26 08:48:15 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #31970: [SPARK-34874][INFRA] Recover test reports for failed GA builds

HyukjinKwon opened a new pull request #31970:
URL: https://github.com/apache/spark/pull/31970


   ### What changes were proposed in this pull request?
   
   https://github.com/dawidd6/action-download-artifact/commit/621becc6d7c440318382ce6f4cb776f27dd3fef3#r48726074 there was a behaviour change in the download artifact plugin and it disabled the test reporting in failed builds.
   
   This PR recovers it by explicitly setting the conclusion from the workflow runs to search for the artifacts to download.
   
   ### Why are the changes needed?
   
   In order to properly report the failed test cases.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, it's dev only.
   
   ### How was this patch tested?
   
   Manually tested at https://github.com/HyukjinKwon/spark/pull/30
   
   Before:
   
   ![Screen Shot 2021-03-26 at 10 54 48 AM](https://user-images.githubusercontent.com/6477701/112566110-b7951d80-8e21-11eb-8fad-f637db9314d5.png)
   
   After:
   
   ![Screen Shot 2021-03-26 at 10 54 48 AM](https://user-images.githubusercontent.com/6477701/112606131-6013a380-8e5b-11eb-845b-5f6fc302b310.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #31970: [SPARK-34874][INFRA] Recover test reports for failed GA builds

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31970:
URL: https://github.com/apache/spark/pull/31970


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31970: [SPARK-34874][INFRA] Recover test reports for failed GA builds

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31970:
URL: https://github.com/apache/spark/pull/31970#issuecomment-808059238


   Thanks! Merged to master, branch-3.1, branch-3.0 and branch-2.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31970: [SPARK-34874][INFRA] Recover test reports for failed GA builds

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31970:
URL: https://github.com/apache/spark/pull/31970#issuecomment-808502859


   +1, late LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31970: [SPARK-34874][INFRA] Recover test reports for failed GA builds

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31970:
URL: https://github.com/apache/spark/pull/31970#issuecomment-808045850


   cc @gengliangwang, @viirya or @dongjoon-hyun can you take a quick look please? This change cannot be tested in this PR anyway because the workflow runs against the master branch's workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org