You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Bill van Melle (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 23:27:10 UTC
[jira] [Created] (PIVOT-803) ImageView placement is incorrect when
nested inside two TablePanes
ImageView placement is incorrect when nested inside two TablePanes
------------------------------------------------------------------
Key: PIVOT-803
URL: https://issues.apache.org/jira/browse/PIVOT-803
Project: Pivot
Issue Type: Bug
Components: wtk
Affects Versions: 2.0, 2.0.1
Reporter: Bill van Melle
Priority: Minor
If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-803) ImageView placement is incorrect
when nested inside two TablePanes
Posted by "Sandro Martini (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134527#comment-13134527 ]
Sandro Martini commented on PIVOT-803:
--------------------------------------
Just commited test case (here in attach), but as pivot_803 , in the same package as other tests.
Noel when you want, resolve this issue ... to me looks good.
Bye
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Bill van Melle
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-803) ImageView placement is incorrect when
nested inside two TablePanes
Posted by "Bill van Melle (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill van Melle updated PIVOT-803:
---------------------------------
Attachment: test.zip
This is a TablePane with two columns. In the first column, I demonstrate the bug by placing a TablePane in the cell, and within that an ImageView. In the second column I place the same ImageView unnested, which displays correctly.
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0, 2.0.1
> Reporter: Bill van Melle
> Priority: Minor
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-803) ImageView placement is incorrect
when nested inside two TablePanes
Posted by "Bill van Melle (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140691#comment-13140691 ]
Bill van Melle commented on PIVOT-803:
--------------------------------------
Thanks for the quick fix, this seems to have fixed the problem for me. (Sorry for the delay in replying -- I filed the ticket and then went on vacation.)
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Bill van Melle
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-803) ImageView placement is incorrect
when nested inside two TablePanes
Posted by "Noel Grandin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130700#comment-13130700 ]
Noel Grandin commented on PIVOT-803:
------------------------------------
I've checked in a basic fix in rev 1186281
The problem was that TablePane was not dealing with the case where it had insufficient space.
This is a bit of a blunt solution, but at least it's simple.
Bill, please test and see how it works for you.
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0, 2.0.1
> Reporter: Bill van Melle
> Priority: Minor
> Fix For: 2.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-803) ImageView placement is incorrect
when nested inside two TablePanes
Posted by "Bill van Melle (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130143#comment-13130143 ]
Bill van Melle commented on PIVOT-803:
--------------------------------------
I traced thru the code to see that, as Greg observed, the inner TablePane is computing the height of its row to be larger than the constrained height of the TablePane itself.
I should note that in my toy example, a workaround is to redundantly specify the height of the inner TablePane's first row to be the same as the height of the row the TablePane is in. But for more complex layouts (i.e., where the outer row doesn't have a set height), I don't think there's something quite so simple to fix it.
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0, 2.0.1
> Reporter: Bill van Melle
> Priority: Minor
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-803) ImageView placement is incorrect when
nested inside two TablePanes
Posted by "Noel Grandin (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noel Grandin resolved PIVOT-803.
--------------------------------
Resolution: Fixed
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Bill van Melle
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-803) ImageView placement is incorrect when
nested inside two TablePanes
Posted by "Sandro Martini (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-803:
---------------------------------
Affects Version/s: (was: 2.0.1)
Fix Version/s: (was: 2.1)
2.0.1
Assignee: Noel Grandin
Reassigned, so maybe (after your commit) we can resolve even this in 2.0.1 .... let's wait Bill feedback.
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Bill van Melle
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-803) ImageView placement is incorrect when
nested inside two TablePanes
Posted by "Sandro Martini (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini updated PIVOT-803:
---------------------------------
Fix Version/s: 2.1
>I don't think there's something quite so simple to fix it.
Ok, so assigned to 2.1 ... but if someone finds a solution before, be free to reassign to a 2.0.x release.
> ImageView placement is incorrect when nested inside two TablePanes
> ------------------------------------------------------------------
>
> Key: PIVOT-803
> URL: https://issues.apache.org/jira/browse/PIVOT-803
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0, 2.0.1
> Reporter: Bill van Melle
> Priority: Minor
> Fix For: 2.1
>
> Attachments: test.zip
>
>
> If you have an ImageView nested two levels deep inside a TablePane, the image is aligned incorrectly. I've seen cases that vary from no problem to the top coordinate being so large that the image doesn't display at all.
> I wrote about this a long time ago (http://apache-pivot-users.399431.n3.nabble.com/ImageView-messes-up-nested-inside-two-TablePanes-td2514398.html) but apparently neglected to file a bug report. At the time, Greg suggested that the layout code was passing the wrong height to the ImageView.
> I'll attach a test case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira