[GitHub] [geode] dschneider-pivotal commented on pull request #4294: GEODE-7229: adding autoSerializer to pdx and removing the persistent attribute

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

In this particular case, we should not make it easy to use the default disk store. The PCC team, for example, recently went through a difficult upgrade to switch pdx from the default disk store to a dedicated pdx disk store. Having the pdx types stores in the same disk store as the region data can cause issues down the road. So this particular change I think is good because it forces a user to explicitly say "I want my pdx to use the DEFAULT disk store".

If we decide to make it easy to use the default disk store for pdx then I'm not sure I like doing it by adding a setPersistent() method. This would only be of help to users of the java management api; not the rest management api users. I think we want to keep a close correspondence between the java and rest management apis. 

I also don't like us having methods that look like a settor that have no corresponding attribute. Users expect if they call setPersistent and then print out the config to see something like "persistent=true" not "diskStoreName=DEFAULT".

[ Full content available at: https://github.com/apache/geode/pull/4294 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org