You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Nick Dimiduk <nd...@gmail.com> on 2014/11/06 23:24:18 UTC

Re: KeyValue#createFirstOnRow() removed in hbase branch-1

+dev@hbase

On Wednesday, November 5, 2014, Anoop John <an...@gmail.com> wrote:

> I see Phoenix using this API in many places..  So how about add it back in
> branch-1 with deprecation and remove from trunk(?)  Might be some other
> users also have used it. Deprecate in one major version and remove in next
> major version seems better.
>
> -Anoop-
>
> On Thu, Nov 6, 2014 at 12:06 AM, Ted Yu <yuzhihong@gmail.com
> <javascript:;>> wrote:
>
> > Hi,
> > In hbase branch-1, KeyValue.createFirstOnRow() doesn't
> > exist. KeyValueUtil.createFirstOnRow() replaces that method.
> >
> > I want to get opinion on how Phoenix should deal with such API
> > compatibility issue now that hbase 1.0 release gets closer.
> >
> > Cheers
> >
>

Re: KeyValue#createFirstOnRow() removed in hbase branch-1

Posted by Ted Yu <yu...@gmail.com>.
I logged HBASE-12442 and attached an initial patch there.

Thanks

On Thu, Nov 6, 2014 at 7:57 PM, ramkrishna vasudevan <
ramkrishna.s.vasudevan@gmail.com> wrote:

> Ok. +1 on  bringing it back with @deprecated tag in one major version and
> removing it in the next major version.
>
> Regards
> Ram
>
> On Fri, Nov 7, 2014 at 3:54 AM, Nick Dimiduk <nd...@gmail.com> wrote:
>
> > +dev@hbase
> >
> > On Wednesday, November 5, 2014, Anoop John <an...@gmail.com>
> wrote:
> >
> > > I see Phoenix using this API in many places..  So how about add it back
> > in
> > > branch-1 with deprecation and remove from trunk(?)  Might be some other
> > > users also have used it. Deprecate in one major version and remove in
> > next
> > > major version seems better.
> > >
> > > -Anoop-
> > >
> > > On Thu, Nov 6, 2014 at 12:06 AM, Ted Yu <yuzhihong@gmail.com
> > > <javascript:;>> wrote:
> > >
> > > > Hi,
> > > > In hbase branch-1, KeyValue.createFirstOnRow() doesn't
> > > > exist. KeyValueUtil.createFirstOnRow() replaces that method.
> > > >
> > > > I want to get opinion on how Phoenix should deal with such API
> > > > compatibility issue now that hbase 1.0 release gets closer.
> > > >
> > > > Cheers
> > > >
> > >
> >
>

Re: KeyValue#createFirstOnRow() removed in hbase branch-1

Posted by Ted Yu <yu...@gmail.com>.
I logged HBASE-12442 and attached an initial patch there.

Thanks

On Thu, Nov 6, 2014 at 7:57 PM, ramkrishna vasudevan <
ramkrishna.s.vasudevan@gmail.com> wrote:

> Ok. +1 on  bringing it back with @deprecated tag in one major version and
> removing it in the next major version.
>
> Regards
> Ram
>
> On Fri, Nov 7, 2014 at 3:54 AM, Nick Dimiduk <nd...@gmail.com> wrote:
>
> > +dev@hbase
> >
> > On Wednesday, November 5, 2014, Anoop John <an...@gmail.com>
> wrote:
> >
> > > I see Phoenix using this API in many places..  So how about add it back
> > in
> > > branch-1 with deprecation and remove from trunk(?)  Might be some other
> > > users also have used it. Deprecate in one major version and remove in
> > next
> > > major version seems better.
> > >
> > > -Anoop-
> > >
> > > On Thu, Nov 6, 2014 at 12:06 AM, Ted Yu <yuzhihong@gmail.com
> > > <javascript:;>> wrote:
> > >
> > > > Hi,
> > > > In hbase branch-1, KeyValue.createFirstOnRow() doesn't
> > > > exist. KeyValueUtil.createFirstOnRow() replaces that method.
> > > >
> > > > I want to get opinion on how Phoenix should deal with such API
> > > > compatibility issue now that hbase 1.0 release gets closer.
> > > >
> > > > Cheers
> > > >
> > >
> >
>

Re: KeyValue#createFirstOnRow() removed in hbase branch-1

Posted by ramkrishna vasudevan <ra...@gmail.com>.
Ok. +1 on  bringing it back with @deprecated tag in one major version and
removing it in the next major version.

Regards
Ram

On Fri, Nov 7, 2014 at 3:54 AM, Nick Dimiduk <nd...@gmail.com> wrote:

> +dev@hbase
>
> On Wednesday, November 5, 2014, Anoop John <an...@gmail.com> wrote:
>
> > I see Phoenix using this API in many places..  So how about add it back
> in
> > branch-1 with deprecation and remove from trunk(?)  Might be some other
> > users also have used it. Deprecate in one major version and remove in
> next
> > major version seems better.
> >
> > -Anoop-
> >
> > On Thu, Nov 6, 2014 at 12:06 AM, Ted Yu <yuzhihong@gmail.com
> > <javascript:;>> wrote:
> >
> > > Hi,
> > > In hbase branch-1, KeyValue.createFirstOnRow() doesn't
> > > exist. KeyValueUtil.createFirstOnRow() replaces that method.
> > >
> > > I want to get opinion on how Phoenix should deal with such API
> > > compatibility issue now that hbase 1.0 release gets closer.
> > >
> > > Cheers
> > >
> >
>

Re: KeyValue#createFirstOnRow() removed in hbase branch-1

Posted by ramkrishna vasudevan <ra...@gmail.com>.
Ok. +1 on  bringing it back with @deprecated tag in one major version and
removing it in the next major version.

Regards
Ram

On Fri, Nov 7, 2014 at 3:54 AM, Nick Dimiduk <nd...@gmail.com> wrote:

> +dev@hbase
>
> On Wednesday, November 5, 2014, Anoop John <an...@gmail.com> wrote:
>
> > I see Phoenix using this API in many places..  So how about add it back
> in
> > branch-1 with deprecation and remove from trunk(?)  Might be some other
> > users also have used it. Deprecate in one major version and remove in
> next
> > major version seems better.
> >
> > -Anoop-
> >
> > On Thu, Nov 6, 2014 at 12:06 AM, Ted Yu <yuzhihong@gmail.com
> > <javascript:;>> wrote:
> >
> > > Hi,
> > > In hbase branch-1, KeyValue.createFirstOnRow() doesn't
> > > exist. KeyValueUtil.createFirstOnRow() replaces that method.
> > >
> > > I want to get opinion on how Phoenix should deal with such API
> > > compatibility issue now that hbase 1.0 release gets closer.
> > >
> > > Cheers
> > >
> >
>