You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/09/12 14:36:16 UTC
(commons-net) 04/04: Convert cascading if-else to switch
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit c6557d391ab75e339c3fc11e0a90fff5007be9a3
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 12 10:36:05 2024 -0400
Convert cascading if-else to switch
---
.../commons/net/examples/ftp/TFTPExample.java | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/examples/ftp/TFTPExample.java b/src/main/java/org/apache/commons/net/examples/ftp/TFTPExample.java
index 7c6ee9cd..76feaf9d 100644
--- a/src/main/java/org/apache/commons/net/examples/ftp/TFTPExample.java
+++ b/src/main/java/org/apache/commons/net/examples/ftp/TFTPExample.java
@@ -79,22 +79,30 @@ public final class TFTPExample {
if (!arg.startsWith("-")) {
break;
}
- if (arg.equals("-r")) {
+ switch (arg) {
+ case "-r":
receiveFile = true;
- } else if (arg.equals("-s")) {
+ break;
+ case "-s":
receiveFile = false;
- } else if (arg.equals("-a")) {
+ break;
+ case "-a":
transferMode = TFTP.ASCII_MODE;
- } else if (arg.equals("-b")) {
+ break;
+ case "-b":
transferMode = TFTP.BINARY_MODE;
- } else if (arg.equals("-t")) {
+ break;
+ case "-t":
timeout = 1000 * Integer.parseInt(args[++argc]);
- } else if (arg.equals("-v")) {
+ break;
+ case "-v":
verbose = true;
- } else {
+ break;
+ default:
System.err.println("Error: unrecognized option.");
System.err.print(USAGE);
System.exit(1);
+ break;
}
}