You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2015/05/13 08:45:39 UTC
[3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert "Revert
"SCRIPT_HOME path had extra slash""
Revert "Revert "SCRIPT_HOME path had extra slash""
This reverts commit e9be91b7be0a4125fe68b3b62f98ce69b6baecc5.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b0aec132
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b0aec132
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b0aec132
Branch: refs/heads/develop
Commit: b0aec13227223d0bd388d535e65145bfd6ce1afd
Parents: e9be91b
Author: Erik de Bruin <er...@ixsoftware.nl>
Authored: Wed May 13 08:44:30 2015 +0200
Committer: Erik de Bruin <er...@ixsoftware.nl>
Committed: Wed May 13 08:44:30 2015 +0200
----------------------------------------------------------------------
js/bin/mxmlc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0aec132/js/bin/mxmlc
----------------------------------------------------------------------
diff --git a/js/bin/mxmlc b/js/bin/mxmlc
index 9609620..ca92abb 100755
--- a/js/bin/mxmlc
+++ b/js/bin/mxmlc
@@ -67,4 +67,4 @@ fi
VMARGS="-Xmx384m -Dsun.io.useCanonCaches=false "
-java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" -Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME/../lib/mxmlc.jar" +flexlib="$FLEX_HOME/frameworks" -js-output-type=FLEXJS -sdk-js-lib="$FLEX_HOME/frameworks/js/FlexJS/src" "$@"
+java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" -Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME../lib/mxmlc.jar" +flexlib="$FLEX_HOME/frameworks" -js-output-type=FLEXJS -sdk-js-lib="$FLEX_HOME/frameworks/js/FlexJS/src" "$@"
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
The pull request was submitted per your suggestion[0].
I was looking at the permission of the mxmlc file in /compiler/commandline/
in the flex-falcon repo and found that it was executable when running ls -l
on its directory. It's weird that when it gets copied to the nightly flexjs
sdk via the installer that it loses the executable permissions. I did see a
chmod tag in the build.xml but I am not sure what script or file decides how
the files get chmod'd.
[0]https://github.com/apache/flex-asjs/pull/2
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46748.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
I will do that in about 5 hours when I get home.
On Thursday, May 14, 2015, Alex Harui [via Apache Flex Development] <
ml-node+s2333347n46550h97@n4.nabble.com> wrote:
> OK, can you generate a pull request for this change?
>
> Thanks,
> -Alex
>
> On 5/14/15, 4:01 AM, "kevin.godell" <[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=46550&i=0>> wrote:
>
> >Alex Harui wrote
> >> Hi Kevin,
> >>
> >> Yes, shell scripts are a whole different language. I’m no expert
> >>either.
> >>
> >> I think there is a fourth scenario, where FALCON_HOME is set to a
> folder
> >> in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead
> >>of
> >> SCRIPT_HOME.
> >>
> >> To me, the issue appears to be this portion of the script:
> >>
> >> if [ "x${FALCON_HOME}" = "x" ]
> >> then
> >> SCRIPT_HOME=`dirname $0`
> >> FALCON_HOME=${SCRIPT_HOME}/../..
> >> fi
> >>
> >> I think this might need to have SCRIPT_HOME taken out of the if/then
> and
> >> run earlier. Because if FALCON_HOME is set, then SCRIPT_HOME never
> gets
> >> set
> >
> >Yes, that makes sense now. I tried to run the script with the 3 scenarios
> >of
> >unset, trailing slash, and no slash with the code changed to:
> >SCRIPT_HOME=`dirname $0`
> >if [ "x${FALCON_HOME}" = "x" ]
> >then
> > FALCON_HOME=${SCRIPT_HOME}/../..
> >fi
> >
> >and
> >
> >-jar "$SCRIPT_HOME/../lib/mxmlc.jar"
> >
> >It worked.
> >
> >
> >
> >--
> >View this message in context:
> >
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
> >x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>
> >p46455p46505.html
> >Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46550.html
> To start a new topic under Apache Flex Development, email
> ml-node+s2333347n1h78@n4.nabble.com
> <javascript:_e(%7B%7D,'cvml','ml-node%2Bs2333347n1h78@n4.nabble.com');>
> To unsubscribe from Re: [3/3] git commit: [flex-asjs] [refs/heads/develop]
> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsLmNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
> .
> NAML
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46558.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
OK, can you generate a pull request for this change?
Thanks,
-Alex
On 5/14/15, 4:01 AM, "kevin.godell" <ke...@gmail.com> wrote:
>Alex Harui wrote
>> Hi Kevin,
>>
>> Yes, shell scripts are a whole different language. I’m no expert
>>either.
>>
>> I think there is a fourth scenario, where FALCON_HOME is set to a folder
>> in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead
>>of
>> SCRIPT_HOME.
>>
>> To me, the issue appears to be this portion of the script:
>>
>> if [ "x${FALCON_HOME}" = "x" ]
>> then
>> SCRIPT_HOME=`dirname $0`
>> FALCON_HOME=${SCRIPT_HOME}/../..
>> fi
>>
>> I think this might need to have SCRIPT_HOME taken out of the if/then and
>> run earlier. Because if FALCON_HOME is set, then SCRIPT_HOME never gets
>> set
>
>Yes, that makes sense now. I tried to run the script with the 3 scenarios
>of
>unset, trailing slash, and no slash with the code changed to:
>SCRIPT_HOME=`dirname $0`
>if [ "x${FALCON_HOME}" = "x" ]
>then
> FALCON_HOME=${SCRIPT_HOME}/../..
>fi
>
>and
>
>-jar "$SCRIPT_HOME/../lib/mxmlc.jar"
>
>It worked.
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46505.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
Alex Harui wrote
> Hi Kevin,
>
> Yes, shell scripts are a whole different language. I’m no expert either.
>
> I think there is a fourth scenario, where FALCON_HOME is set to a folder
> in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead of
> SCRIPT_HOME.
>
> To me, the issue appears to be this portion of the script:
>
> if [ "x${FALCON_HOME}" = "x" ]
> then
> SCRIPT_HOME=`dirname $0`
> FALCON_HOME=${SCRIPT_HOME}/../..
> fi
>
> I think this might need to have SCRIPT_HOME taken out of the if/then and
> run earlier. Because if FALCON_HOME is set, then SCRIPT_HOME never gets
> set
Yes, that makes sense now. I tried to run the script with the 3 scenarios of
unset, trailing slash, and no slash with the code changed to:
SCRIPT_HOME=`dirname $0`
if [ "x${FALCON_HOME}" = "x" ]
then
FALCON_HOME=${SCRIPT_HOME}/../..
fi
and
-jar "$SCRIPT_HOME/../lib/mxmlc.jar"
It worked.
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46505.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
Hi Kevin,
Yes, shell scripts are a whole different language. I’m no expert either.
I think there is a fourth scenario, where FALCON_HOME is set to a folder
in a flex-falcon repo, so I’m not sure you can use FALCON_HOME instead of
SCRIPT_HOME.
To me, the issue appears to be this portion of the script:
if [ "x${FALCON_HOME}" = "x" ]
then
SCRIPT_HOME=`dirname $0`
FALCON_HOME=${SCRIPT_HOME}/../..
fi
I think this might need to have SCRIPT_HOME taken out of the if/then and
run earlier. Because if FALCON_HOME is set, then SCRIPT_HOME never gets
set
Thanks,
-Alex
On 5/13/15, 8:43 PM, "kevin.godell" <ke...@gmail.com> wrote:
>I tried to post earlier, but it seems to have been lost. Hopefully this
>will
>not be a double post.
>
>Leaving the mxmlc as it was before the patch, this was my results calling
>it
>from command line taking intellij out of the picture for the moment.
>
>env var FLEX_HOME and FALCON_HOME set to
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
>Error: Unable to access jarfile /../lib/mxmlc.jar
>
>env var FLEX_HOME and FALCON_HOME set to
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
>Error: Unable to access jarfile /../lib/mxmlc.jar
>
>unset FLEX_HOME and FALCON_HOME
>
>Kevins-MBP:~ kevinGodell$
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest
>.mxml
>Using Falcon codebase:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
>Using Flex SDK:
>/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
>Compiling file:
>/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/bin/js-debug/DataBi
>ndingTest.js
>…and then it completes
>
>Later I edited the mxmlc and changed the mxmlc.jar reference to -jar
>"$FALCON_HOME/js/lib/mxmlc.jar" . This satisfied all 3 situations tested:
>no
>env vars, vars set with trailing slash, and then without trailing slash. I
>dont know if this covers every possible scenario. And just for the
>record, I
>had to read some tuts just to understand the basic structure of shell
>scripting, so don't trust it on my word alone.
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46493.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
I tried to post earlier, but it seems to have been lost. Hopefully this will
not be a double post.
Leaving the mxmlc as it was before the patch, this was my results calling it
from command line taking intellij out of the picture for the moment.
env var FLEX_HOME and FALCON_HOME set to
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
Kevins-MBP:~ kevinGodell$
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest.mxml
Using Falcon codebase:
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/
Error: Unable to access jarfile /../lib/mxmlc.jar
env var FLEX_HOME and FALCON_HOME set to
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
Kevins-MBP:~ kevinGodell$
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest.mxml
Using Falcon codebase:
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
Using Flex SDK: /Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17
Error: Unable to access jarfile /../lib/mxmlc.jar
unset FLEX_HOME and FALCON_HOME
Kevins-MBP:~ kevinGodell$
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/mxmlc
/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/src/DataBindingTest.mxml
Using Falcon codebase:
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
Using Flex SDK:
/Users/kevinGodell/Documents/flexJS-nightly_air-17_fp-17/js/bin/../..
Compiling file:
/Users/kevinGodell/IdeaProjects/flexJS/DataBindingTest/bin/js-debug/DataBindingTest.js
…and then it completes
Later I edited the mxmlc and changed the mxmlc.jar reference to -jar
"$FALCON_HOME/js/lib/mxmlc.jar" . This satisfied all 3 situations tested: no
env vars, vars set with trailing slash, and then without trailing slash. I
dont know if this covers every possible scenario. And just for the record, I
had to read some tuts just to understand the basic structure of shell
scripting, so don't trust it on my word alone.
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46493.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
Hi Kevin,
Before we revert that, I think folks with multiple SDKs are going to want
to set FLEX_HOME and maybe FALCON_HOME too. It would be nice to see if we
can make the scripts work in either situation if you have time.
-Alex
On 5/13/15, 5:06 PM, "kevin.godell" <ke...@gmail.com> wrote:
>Sorry. please revert that change. For some reason that I cant remember
>right
>now, I thought that I had to setup the environment variables for FLEX_HOME
>and FALCON_HOME. Having those set, it causes that SCRIPT_HOME part to end
>up
>with that error. When I removed the env vars, and put the mxmlc back to
>the
>original, it was just fine. Once again, sorry for the unnecessary pull
>request.
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46490.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
Sorry. please revert that change. For some reason that I cant remember right
now, I thought that I had to setup the environment variables for FLEX_HOME
and FALCON_HOME. Having those set, it causes that SCRIPT_HOME part to end up
with that error. When I removed the env vars, and put the mxmlc back to the
original, it was just fine. Once again, sorry for the unnecessary pull
request.
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46490.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
In theory, if you don’t define any environment variables, and mxmlc is in
the js/bin folder, it should be able to use SCRIPT_HOME to back up a few
levels and assume FLEX_HOME and FALCON_HOME is there.
But of course, this is all theory. Examining the bin/mxmlc might shed
some light on what is broken in js/bin/mxmlc.
For me, the script did work without modification and without environment
variables if I changed directories to js/bin and ran mxmlc from there.
Again, thanks for helping out,
-Alex
On 5/13/15, 7:51 AM, "kevin.godell" <ke...@gmail.com> wrote:
>So, am I suppose to define env vars for flexhome and falconhome? It
>doesn't
>work if I don't.
>
>On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
>ml-node+s2333347n46467h24@n4.nabble.com> wrote:
>
>> SCRIPT_HOME is supposed to be the directory the shell script is in so
>>that
>> it can use relative paths from there to find other things. I’d prefer
>>not
>> to require environment variables as I think there are similar scripts in
>> the Flex SDK that don’t require environment variables, but I could be
>> wrong about that.
>>
>> Thanks for helping out,
>> -Alex
>>
>> On 5/13/15, 7:43 AM, "kevin.godell" <[hidden email]
>> <http:///user/SendEmail.jtp?type=node&node=46467&i=0>> wrote:
>>
>> >I will try to put in some echo statements and see whst scripthome is
>> being
>> >defined as when I get home tonight. I am not familiar with shell
>> >scripting,
>> >but it looks like I could mess with it. Could that be defined as an
>> >environmental variable? I know that I have to set flexhome and
>>falconhome
>> >to make mxmlc work using env vars.
>> >
>> >On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
>> >[hidden email] <http:///user/SendEmail.jtp?type=node&node=46467&i=1>>
>> wrote:
>> >
>> >>
>> >>
>> >> On 5/13/15, 4:35 AM, "kevin.godell" <[hidden email]
>> >> <http:///user/SendEmail.jtp?type=node&node=46461&i=0>> wrote:
>> >>
>> >> >I hope that the patch wasn't the cause of the build failing!
>> >>
>> >> The build likes to fail waiting for flexunit results. At some point
>>it
>> >> will get past that failure point.
>> >> That said, I’m not 100% sure that was the right patch. IMO, the
>> problem
>> >> is that SCRIPT_HOME isn’t being set for some scenarios. If
>>SCRIPT_HOME
>> >> does get set, I think you do want the slash. But I could be wrong
>> about
>> >> that.
>> >>
>> >> >
>> >> >Quick question for you, I need to change the file permissions on the
>> >> >/bin/mxmlc so that it is user executable. Every time I download the
>> >> flexjs
>> >> >nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain
>> about
>> >> >the
>> >> >permission to execute. I understand how to edit a file using the
>> online
>> >> >interface on github, but how do you change the permissions of a
>>file?
>> >>And
>> >> >do
>> >> >you know which repo that file is contained in? The installer grabs
>>the
>> >> >files
>> >> >and puts them all together for me, so I don't really know where it
>> >>lives
>> >> >before making it to my flexjs sdk.
>> >> >
>> >>
>> >> I think bin/mxmlc comes in from the Falcon install in flex-falcon
>>repo.
>> >> The file is in the compiler/commandline folder. The install script
>> >>should
>> >> be in root of flex-falcon in installer.xml, and the file gets
>>packaged
>> >>by
>> >> build.xml. Not sure where the right place is to do the chmod, but
>> there
>> >> is probably other chmod going on for js/bin somehow.
>> >>
>> >> Thanks again for your help on this.
>> >>
>> >> -Alex
>> >>
>> >>
>> >>
>> >> ------------------------------
>> >> If you reply to this email, your message will be added to the
>> >>discussion
>> >> below:
>> >>
>> >>
>> >>
>>
>>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fl
>>
>>>>ex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-sla
>>>>sh
>>
>> >>-tp46455p46461.html
>> >> To start a new topic under Apache Flex Development, email
>> >> [hidden email] <http:///user/SendEmail.jtp?type=node&node=46467&i=2>
>> >> <javascript:_e(%7B%7D,'cvml','ml-node%[hidden email]
>> <http:///user/SendEmail.jtp?type=node&node=46467&i=3>');>
>> >> To unsubscribe from Re: [3/3] git commit: [flex-asjs]
>> >>[refs/heads/develop]
>> >> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
>> >>
>> >><
>> >>mNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
>> >> .
>> >> NAML
>> >>
>> >><
>>
>><http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>>
>> http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>
>>>>t.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nab
>>>>bl
>>
>>
>>>>e.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespa
>>>>ce
>>
>>
>>>>-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%
>>>>21
>>
>>
>>>>nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_e
>>>>ma
>>
>> >>il%21nabble%3Aemail.naml>
>> >>
>> >
>> >
>> >
>> >
>> >--
>> >View this message in context:
>> >
>>
>>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fl
>>e
>>
>>>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash
>>>-t
>>
>> >p46455p46464.html
>> >Sent from the Apache Flex Development mailing list archive at
>>Nabble.com.
>>
>>
>>
>> ------------------------------
>> If you reply to this email, your message will be added to the
>>discussion
>> below:
>>
>>
>>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fl
>>ex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash
>>-tp46455p46467.html
>> To start a new topic under Apache Flex Development, email
>> ml-node+s2333347n1h78@n4.nabble.com
>> To unsubscribe from Re: [3/3] git commit: [flex-asjs]
>>[refs/heads/develop]
>> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
>>
>><http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>t.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsL
>>mNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
>> .
>> NAML
>>
>><http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>t.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabbl
>>e.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace
>>-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21
>>nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_ema
>>il%21nabble%3Aemail.naml>
>>
>
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46468.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
So, am I suppose to define env vars for flexhome and falconhome? It doesn't
work if I don't.
On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
ml-node+s2333347n46467h24@n4.nabble.com> wrote:
> SCRIPT_HOME is supposed to be the directory the shell script is in so that
> it can use relative paths from there to find other things. I’d prefer not
> to require environment variables as I think there are similar scripts in
> the Flex SDK that don’t require environment variables, but I could be
> wrong about that.
>
> Thanks for helping out,
> -Alex
>
> On 5/13/15, 7:43 AM, "kevin.godell" <[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=46467&i=0>> wrote:
>
> >I will try to put in some echo statements and see whst scripthome is
> being
> >defined as when I get home tonight. I am not familiar with shell
> >scripting,
> >but it looks like I could mess with it. Could that be defined as an
> >environmental variable? I know that I have to set flexhome and falconhome
> >to make mxmlc work using env vars.
> >
> >On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
> >[hidden email] <http:///user/SendEmail.jtp?type=node&node=46467&i=1>>
> wrote:
> >
> >>
> >>
> >> On 5/13/15, 4:35 AM, "kevin.godell" <[hidden email]
> >> <http:///user/SendEmail.jtp?type=node&node=46461&i=0>> wrote:
> >>
> >> >I hope that the patch wasn't the cause of the build failing!
> >>
> >> The build likes to fail waiting for flexunit results. At some point it
> >> will get past that failure point.
> >> That said, I’m not 100% sure that was the right patch. IMO, the
> problem
> >> is that SCRIPT_HOME isn’t being set for some scenarios. If SCRIPT_HOME
> >> does get set, I think you do want the slash. But I could be wrong
> about
> >> that.
> >>
> >> >
> >> >Quick question for you, I need to change the file permissions on the
> >> >/bin/mxmlc so that it is user executable. Every time I download the
> >> flexjs
> >> >nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain
> about
> >> >the
> >> >permission to execute. I understand how to edit a file using the
> online
> >> >interface on github, but how do you change the permissions of a file?
> >>And
> >> >do
> >> >you know which repo that file is contained in? The installer grabs the
> >> >files
> >> >and puts them all together for me, so I don't really know where it
> >>lives
> >> >before making it to my flexjs sdk.
> >> >
> >>
> >> I think bin/mxmlc comes in from the Falcon install in flex-falcon repo.
> >> The file is in the compiler/commandline folder. The install script
> >>should
> >> be in root of flex-falcon in installer.xml, and the file gets packaged
> >>by
> >> build.xml. Not sure where the right place is to do the chmod, but
> there
> >> is probably other chmod going on for js/bin somehow.
> >>
> >> Thanks again for your help on this.
> >>
> >> -Alex
> >>
> >>
> >>
> >> ------------------------------
> >> If you reply to this email, your message will be added to the
> >>discussion
> >> below:
> >>
> >>
> >>
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fl
> >>ex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash
>
> >>-tp46455p46461.html
> >> To start a new topic under Apache Flex Development, email
> >> [hidden email] <http:///user/SendEmail.jtp?type=node&node=46467&i=2>
> >> <javascript:_e(%7B%7D,'cvml','ml-node%[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=46467&i=3>');>
> >> To unsubscribe from Re: [3/3] git commit: [flex-asjs]
> >>[refs/heads/develop]
> >> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
> >>
> >><
> >>mNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
> >> .
> >> NAML
> >>
> >><
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle>
> http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
> >>t.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabbl
>
> >>e.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace
>
> >>-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21
>
> >>nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_ema
>
> >>il%21nabble%3Aemail.naml>
> >>
> >
> >
> >
> >
> >--
> >View this message in context:
> >
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
> >x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>
> >p46455p46464.html
> >Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46467.html
> To start a new topic under Apache Flex Development, email
> ml-node+s2333347n1h78@n4.nabble.com
> To unsubscribe from Re: [3/3] git commit: [flex-asjs] [refs/heads/develop]
> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsLmNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
> .
> NAML
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46468.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
SCRIPT_HOME is supposed to be the directory the shell script is in so that
it can use relative paths from there to find other things. I’d prefer not
to require environment variables as I think there are similar scripts in
the Flex SDK that don’t require environment variables, but I could be
wrong about that.
Thanks for helping out,
-Alex
On 5/13/15, 7:43 AM, "kevin.godell" <ke...@gmail.com> wrote:
>I will try to put in some echo statements and see whst scripthome is being
>defined as when I get home tonight. I am not familiar with shell
>scripting,
>but it looks like I could mess with it. Could that be defined as an
>environmental variable? I know that I have to set flexhome and falconhome
>to make mxmlc work using env vars.
>
>On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
>ml-node+s2333347n46461h38@n4.nabble.com> wrote:
>
>>
>>
>> On 5/13/15, 4:35 AM, "kevin.godell" <[hidden email]
>> <http:///user/SendEmail.jtp?type=node&node=46461&i=0>> wrote:
>>
>> >I hope that the patch wasn't the cause of the build failing!
>>
>> The build likes to fail waiting for flexunit results. At some point it
>> will get past that failure point.
>> That said, I’m not 100% sure that was the right patch. IMO, the problem
>> is that SCRIPT_HOME isn’t being set for some scenarios. If SCRIPT_HOME
>> does get set, I think you do want the slash. But I could be wrong about
>> that.
>>
>> >
>> >Quick question for you, I need to change the file permissions on the
>> >/bin/mxmlc so that it is user executable. Every time I download the
>> flexjs
>> >nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain about
>> >the
>> >permission to execute. I understand how to edit a file using the online
>> >interface on github, but how do you change the permissions of a file?
>>And
>> >do
>> >you know which repo that file is contained in? The installer grabs the
>> >files
>> >and puts them all together for me, so I don't really know where it
>>lives
>> >before making it to my flexjs sdk.
>> >
>>
>> I think bin/mxmlc comes in from the Falcon install in flex-falcon repo.
>> The file is in the compiler/commandline folder. The install script
>>should
>> be in root of flex-falcon in installer.xml, and the file gets packaged
>>by
>> build.xml. Not sure where the right place is to do the chmod, but there
>> is probably other chmod going on for js/bin somehow.
>>
>> Thanks again for your help on this.
>>
>> -Alex
>>
>>
>>
>> ------------------------------
>> If you reply to this email, your message will be added to the
>>discussion
>> below:
>>
>>
>>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fl
>>ex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash
>>-tp46455p46461.html
>> To start a new topic under Apache Flex Development, email
>> ml-node+s2333347n1h78@n4.nabble.com
>> <javascript:_e(%7B%7D,'cvml','ml-node%2Bs2333347n1h78@n4.nabble.com');>
>> To unsubscribe from Re: [3/3] git commit: [flex-asjs]
>>[refs/heads/develop]
>> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
>>
>><http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>t.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsL
>>mNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
>> .
>> NAML
>>
>><http://apache-flex-development.2333347.n4.nabble.com/template/NamlServle
>>t.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabbl
>>e.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace
>>-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21
>>nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_ema
>>il%21nabble%3Aemail.naml>
>>
>
>
>
>
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-fle
>x-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-t
>p46455p46464.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
I will try to put in some echo statements and see whst scripthome is being
defined as when I get home tonight. I am not familiar with shell scripting,
but it looks like I could mess with it. Could that be defined as an
environmental variable? I know that I have to set flexhome and falconhome
to make mxmlc work using env vars.
On Wednesday, May 13, 2015, Alex Harui [via Apache Flex Development] <
ml-node+s2333347n46461h38@n4.nabble.com> wrote:
>
>
> On 5/13/15, 4:35 AM, "kevin.godell" <[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=46461&i=0>> wrote:
>
> >I hope that the patch wasn't the cause of the build failing!
>
> The build likes to fail waiting for flexunit results. At some point it
> will get past that failure point.
> That said, I’m not 100% sure that was the right patch. IMO, the problem
> is that SCRIPT_HOME isn’t being set for some scenarios. If SCRIPT_HOME
> does get set, I think you do want the slash. But I could be wrong about
> that.
>
> >
> >Quick question for you, I need to change the file permissions on the
> >/bin/mxmlc so that it is user executable. Every time I download the
> flexjs
> >nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain about
> >the
> >permission to execute. I understand how to edit a file using the online
> >interface on github, but how do you change the permissions of a file? And
> >do
> >you know which repo that file is contained in? The installer grabs the
> >files
> >and puts them all together for me, so I don't really know where it lives
> >before making it to my flexjs sdk.
> >
>
> I think bin/mxmlc comes in from the Falcon install in flex-falcon repo.
> The file is in the compiler/commandline folder. The install script should
> be in root of flex-falcon in installer.xml, and the file gets packaged by
> build.xml. Not sure where the right place is to do the chmod, but there
> is probably other chmod going on for js/bin somehow.
>
> Thanks again for your help on this.
>
> -Alex
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
>
> http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46461.html
> To start a new topic under Apache Flex Development, email
> ml-node+s2333347n1h78@n4.nabble.com
> <javascript:_e(%7B%7D,'cvml','ml-node%2Bs2333347n1h78@n4.nabble.com');>
> To unsubscribe from Re: [3/3] git commit: [flex-asjs] [refs/heads/develop]
> - Revert "Revert "SCRIPT_HOME path had extra slash"", click here
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=46455&code=a2V2aW4uZ29kZWxsQGdtYWlsLmNvbXw0NjQ1NXwyNTAxOTQ4MDU=>
> .
> NAML
> <http://apache-flex-development.2333347.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46464.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Alex Harui <ah...@adobe.com>.
On 5/13/15, 4:35 AM, "kevin.godell" <ke...@gmail.com> wrote:
>I hope that the patch wasn't the cause of the build failing!
The build likes to fail waiting for flexunit results. At some point it
will get past that failure point.
That said, I’m not 100% sure that was the right patch. IMO, the problem
is that SCRIPT_HOME isn’t being set for some scenarios. If SCRIPT_HOME
does get set, I think you do want the slash. But I could be wrong about
that.
>
>Quick question for you, I need to change the file permissions on the
>/bin/mxmlc so that it is user executable. Every time I download the flexjs
>nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain about
>the
>permission to execute. I understand how to edit a file using the online
>interface on github, but how do you change the permissions of a file? And
>do
>you know which repo that file is contained in? The installer grabs the
>files
>and puts them all together for me, so I don't really know where it lives
>before making it to my flexjs sdk.
>
I think bin/mxmlc comes in from the Falcon install in flex-falcon repo.
The file is in the compiler/commandline folder. The install script should
be in root of flex-falcon in installer.xml, and the file gets packaged by
build.xml. Not sure where the right place is to do the chmod, but there
is probably other chmod going on for js/bin somehow.
Thanks again for your help on this.
-Alex
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by "kevin.godell" <ke...@gmail.com>.
I hope that the patch wasn't the cause of the build failing!
Quick question for you, I need to change the file permissions on the
/bin/mxmlc so that it is user executable. Every time I download the flexjs
nightly, I have to chmod 744 mxmlc so that IntelliJ wont complain about the
permission to execute. I understand how to edit a file using the online
interface on github, but how do you change the permissions of a file? And do
you know which repo that file is contained in? The installer grabs the files
and puts them all together for me, so I don't really know where it lives
before making it to my flexjs sdk.
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-3-3-git-commit-flex-asjs-refs-heads-develop-Revert-Revert-SCRIPT-HOME-path-had-extra-slash-tp46455p46460.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [3/3] git commit: [flex-asjs] [refs/heads/develop] - Revert
"Revert "SCRIPT_HOME path had extra slash""
Posted by Erik de Bruin <er...@apache.org>.
Yeah, sorry about the mess, I seem to be a bit rusty :-(
Anyway, Kevin: thanks for the patch!
EdB
On Wed, May 13, 2015 at 8:45 AM, <er...@apache.org> wrote:
> Revert "Revert "SCRIPT_HOME path had extra slash""
>
> This reverts commit e9be91b7be0a4125fe68b3b62f98ce69b6baecc5.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/b0aec132
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/b0aec132
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/b0aec132
>
> Branch: refs/heads/develop
> Commit: b0aec13227223d0bd388d535e65145bfd6ce1afd
> Parents: e9be91b
> Author: Erik de Bruin <er...@ixsoftware.nl>
> Authored: Wed May 13 08:44:30 2015 +0200
> Committer: Erik de Bruin <er...@ixsoftware.nl>
> Committed: Wed May 13 08:44:30 2015 +0200
>
> ----------------------------------------------------------------------
> js/bin/mxmlc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/b0aec132/js/bin/mxmlc
> ----------------------------------------------------------------------
> diff --git a/js/bin/mxmlc b/js/bin/mxmlc
> index 9609620..ca92abb 100755
> --- a/js/bin/mxmlc
> +++ b/js/bin/mxmlc
> @@ -67,4 +67,4 @@ fi
>
> VMARGS="-Xmx384m -Dsun.io.useCanonCaches=false "
>
> -java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" -Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME/../lib/mxmlc.jar" +flexlib="$FLEX_HOME/frameworks" -js-output-type=FLEXJS -sdk-js-lib="$FLEX_HOME/frameworks/js/FlexJS/src" "$@"
> +java $VMARGS $D32 $SETUP_SH_VMARGS -Dflexcompiler="$FALCON_HOME" -Dflexlib="$FLEX_HOME/frameworks" -jar "$SCRIPT_HOME../lib/mxmlc.jar" +flexlib="$FLEX_HOME/frameworks" -js-output-type=FLEXJS -sdk-js-lib="$FLEX_HOME/frameworks/js/FlexJS/src" "$@"
>