You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/10 06:30:03 UTC
[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #7877: [Improvement][API] Add and fix unit test for ExecutorController，Fix A…
zhuangchong commented on a change in pull request #7877:
URL: https://github.com/apache/dolphinscheduler/pull/7877#discussion_r780916246
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
##########
@@ -116,13 +116,13 @@
public Result startProcessInstance(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "processDefinitionCode") long processDefinitionCode,
- @RequestParam(value = "scheduleTime", required = false) String scheduleTime,
- @RequestParam(value = "failureStrategy", required = true) FailureStrategy failureStrategy,
+ @RequestParam(value = "scheduleTime") String scheduleTime,
Review comment:
Why remove `required = false`?
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
##########
@@ -116,13 +116,13 @@
public Result startProcessInstance(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "processDefinitionCode") long processDefinitionCode,
- @RequestParam(value = "scheduleTime", required = false) String scheduleTime,
- @RequestParam(value = "failureStrategy", required = true) FailureStrategy failureStrategy,
+ @RequestParam(value = "scheduleTime") String scheduleTime,
+ @RequestParam(value = "failureStrategy") FailureStrategy failureStrategy,
@RequestParam(value = "startNodeList", required = false) String startNodeList,
@RequestParam(value = "taskDependType", required = false) TaskDependType taskDependType,
@RequestParam(value = "execType", required = false) CommandType execType,
- @RequestParam(value = "warningType", required = true) WarningType warningType,
- @RequestParam(value = "warningGroupId", required = false) int warningGroupId,
+ @RequestParam(value = "warningType") WarningType warningType,
+ @RequestParam(value = "warningGroupId") int warningGroupId,
Review comment:
Why remove `required = false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org