You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 09:33:50 UTC
[GitHub] [airflow] lihan opened a new pull request #21319: Support to upload file to Google Shared Drive
lihan opened a new pull request #21319:
URL: https://github.com/apache/airflow/pull/21319
Adding support to upload file to Shared Drive if file parent is in a Google Shared Drive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21319:
URL: https://github.com/apache/airflow/pull/21319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#discussion_r800157896
##########
File path: tests/providers/google/suite/hooks/test_drive.py
##########
@@ -245,6 +245,7 @@ def test_upload_file_to_root_directory(
body={"name": "remote_path", "parents": ["root"]},
fields="id",
media_body=mock_media_file_upload.return_value,
+ supportsAllDrives=True
Review comment:
```suggestion
supportsAllDrives=True,
```
##########
File path: tests/providers/google/suite/hooks/test_drive.py
##########
@@ -274,6 +275,7 @@ def test_upload_file_to_subdirectory(
body={"name": "remote_path", "parents": ["PARENT_ID"]},
fields="id",
media_body=mock_media_file_upload.return_value,
+ supportsAllDrives=True
Review comment:
```suggestion
supportsAllDrives=True,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030673701
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lihan edited a comment on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
lihan edited a comment on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030733570
@turbaszek @potiuk I updated the tests, can you trigger the Github test again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lihan commented on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
lihan commented on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030733570
@turbaszek I updated the tests, can you trigger the Github test again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030914662
Just intermittent error . merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21319:
URL: https://github.com/apache/airflow/pull/21319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030914717
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21319: Support to upload file to Google Shared Drive
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21319:
URL: https://github.com/apache/airflow/pull/21319#issuecomment-1030685782
Some relevant tests are failing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org