[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9845: Extract apply_ip_allow_filter

["JosiahWI (via GitHub)" <gi...@apache.org>]

JosiahWI commented on code in PR #9845:
URL: https://github.com/apache/trafficserver/pull/9845#discussion_r1231223111


##########
proxy/http/HttpSM.h:
##########
@@ -519,6 +522,18 @@ class HttpSM : public Continuation, public PluginUserArgs<TS_USER_ARGS_TXN>
   /// Update the milestones to track time spent in the plugin API.
   void milestone_update_api_time();
 
+  sockaddr *
+  server_ip() const
+  {
+    return &t_state.current.server->dst_addr.sa;
+  };
+
+  int
+  method() const
+  {
+    return t_state.hdr_info.server_request.method_get_wksidx();
+  };

Review Comment:
   `ip_allow_is_request_forbidden` belongs in IPAllow and I tried it that way - it introduced another cyclic dependency which is probably the greater of the two evils.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org