You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/06/26 11:40:12 UTC
[GitHub] [jackrabbit-oak] kwin opened a new pull request, #1005: OAK-10328 fix scope of "jackrabbit-jcr-tests"
kwin opened a new pull request, #1005:
URL: https://github.com/apache/jackrabbit-oak/pull/1005
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1005: OAK-10328 fix scope of "jackrabbit-jcr-tests"
Posted by "mreutegg (via GitHub)" <gi...@apache.org>.
mreutegg commented on code in PR #1005:
URL: https://github.com/apache/jackrabbit-oak/pull/1005#discussion_r1243431934
##########
oak-jcr/pom.xml:
##########
@@ -423,6 +423,7 @@
<groupId>org.apache.jackrabbit</groupId>
<artifactId>jackrabbit-jcr-tests</artifactId>
<version>${jackrabbit.version}</version>
+ <scope>test</scope>
<optional>true</optional>
Review Comment:
OK, then let's keep it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1005: OAK-10328 fix scope of "jackrabbit-jcr-tests"
Posted by "mreutegg (via GitHub)" <gi...@apache.org>.
mreutegg commented on code in PR #1005:
URL: https://github.com/apache/jackrabbit-oak/pull/1005#discussion_r1242090659
##########
oak-jcr/pom.xml:
##########
@@ -423,6 +423,7 @@
<groupId>org.apache.jackrabbit</groupId>
<artifactId>jackrabbit-jcr-tests</artifactId>
<version>${jackrabbit.version}</version>
+ <scope>test</scope>
<optional>true</optional>
Review Comment:
And at the same time remove optional flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #1005: OAK-10328 fix scope of "jackrabbit-jcr-tests"
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #1005:
URL: https://github.com/apache/jackrabbit-oak/pull/1005#discussion_r1242128102
##########
oak-jcr/pom.xml:
##########
@@ -423,6 +423,7 @@
<groupId>org.apache.jackrabbit</groupId>
<artifactId>jackrabbit-jcr-tests</artifactId>
<version>${jackrabbit.version}</version>
+ <scope>test</scope>
<optional>true</optional>
Review Comment:
Although not considered right now, I think the optional flag kind of indicates, that this is not supposed to be part of the Maven test compile classpath (but only necessary for executing some tests). Maven however does not support this kind of granularity (at least yet), but leaving the optional in does not do any harm, because there is some semantics behind that (not evaluated by Maven apart from having an impact as transitive dependency). I am fine with both leaving or removing, up to you to decide...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin merged pull request #1005: OAK-10328 fix scope of "jackrabbit-jcr-tests"
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #1005:
URL: https://github.com/apache/jackrabbit-oak/pull/1005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org