You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2020/06/16 14:05:00 UTC
[jira] [Comment Edited] (SOLR-8274) Add per-request MDC logging
based on user-provided value.
[ https://issues.apache.org/jira/browse/SOLR-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136677#comment-17136677 ]
Jason Gerlowski edited comment on SOLR-8274 at 6/16/20, 2:04 PM:
-----------------------------------------------------------------
I looked a bit at the OpenTracing docs in the ref-guide, but I'll admit I don't fully understand OpenTracing. The sense I got from reading them was that OpenTracing:
# Required some metric backend to receive tracing info (Datadog, etc.)
# Was geared towards understanding aggregate performance data, rather than having it reliably be present on any given request. (the docs mention only sampling a small percentage of requests by default to avoid affecting performance.)
I'm not sure those takeaways are correct - I'd appreciate being corrected if they're not. But if I've got that right, then it seems like using MDC as this ticket suggests or using the different approach in SOLR-14566 could be valuable supplements to what OpenTracing provides. OpenTracing and logging-improvements would both be valuable in tandem - they don't duplicate functionality, and users might well want one without configuring the other.
But like I said, I might be wrong there.
was (Author: gerlowskija):
I looked a bit at the OpenTracing docs in the ref-guide, but I'll admit I don't fully understand OpenTracing. The sense I got from reading them was that OpenTracing:
# Required some metric backend to receive tracing info (Datadog, etc.)
# Was geared towards understanding aggregate performance data, rather than having it reliably be present on any given request. (the docs mention only sampling a small percentage of requests by default to avoid affecting performance.)
I'm not sure those takeaways are correct - I'd appreciate being corrected if they're not. But if I've got that right, then it seems like using MDC as this ticket suggests or using the different approach in SOLR-14566 could be valuable supplements to what OpenTracing provides. OpenTracing and logging-improvements would both be valuable in tandem, and don't duplicate functionality.
But like I said, I might be wrong there.
> Add per-request MDC logging based on user-provided value.
> ---------------------------------------------------------
>
> Key: SOLR-8274
> URL: https://issues.apache.org/jira/browse/SOLR-8274
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-8274.patch
>
>
> *Problem 1* Currently, there's no way (AFAIK) to find all log messages associated with a particular request.
> *Problem 2* There's also no easy way for multi-tenant Solr setups to find all log messages associated with a particular customer/tenant.
> Both of these problems would be more manageable if Solr could be configured to record an MDC tag based on a header, or some other user provided value.
> This would allow admins to group together logs about a single request. If the same header value is repeated multiple times this functionality could also be used to group together arbitrary requests, such as those that come from a particular user, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org