You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2025/03/17 14:02:01 UTC
[I] [C++] Add `OptionalBitmapAnd` utility [arrow]
pitrou opened a new issue, #45819:
URL: https://github.com/apache/arrow/issues/45819
### Describe the enhancement requested
We currently have `BitmapAnd` utility functions that return the conjunction of two bitmaps.
However, null bitmaps are optional which complicates things when conjoining two null bitmaps. It would be good to centralize that functionality in a dedicated utility function, for example:
```c++
ARROW_EXPORT
Result<std::shared_ptr<Buffer>> OptionalBitmapAnd(
MemoryPool* pool,
const std::shared_ptr<Buffer>& left, int64_t left_offset,
const std::shared_ptr<Buffer>& right, int64_t right_offset,
int64_t length, int64_t out_offset);
```
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4303503320
> given that bitmap_test.cc is already over 1,500 lines, it might be a good time to create bitmap_ops_test.cc and refactor the relevant operation tests there to keep the codebase maintainable.
That sounds like a good idea @Shockp . Thanks for looking at this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #45819: [C++] Add `OptionalBitmapAnd` utility
URL: https://github.com/apache/arrow/issues/45819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4298971738
I will get started on the OptionalBitmapAnd implementation right away. Also, I noticed you are spanish as well :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-2729682982
cc @raulcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4303677499
The PR for OptionalBitmapAnd is up. Let me know if you'd like any adjustments to the implementation or the test coverage. Thanks again for the guidance on the issue @pitrou.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4298920959
I pretty much have this abandoned so feel free to give it a go! I'll assign you the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4303303120
@raulcd @pitrou, I have an initial implementation ready for testing. Should I add these tests to bitmap_test.cc? I noticed there isn't a bitmap_ops_test.cc; given that bitmap_test.cc is already over 1,500 lines, it might be a good time to create bitmap_ops_test.cc and refactor the relevant operation tests there to keep the codebase maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4298908071
Hi @raulcd and @pitrou! I recently got my first C++ PR merged and am looking for a good second issue. I see this is assigned to Raul, are you actively working on this, or is it open for a community contribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add `OptionalBitmapAnd` utility [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45819:
URL: https://github.com/apache/arrow/issues/45819#issuecomment-4353973227
Issue resolved by pull request 49848
https://github.com/apache/arrow/pull/49848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org