You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/06 05:02:25 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements

rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1063105231


##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/Arc.jsx:
##########
@@ -37,11 +37,13 @@ function setTooltipContent(formData) {
   return o => (
     <div className="deckgl-tooltip">
       <TooltipRow
-        label={t('Start (Longitude, Latitude): ')}
+        // eslint-disable-next-line prefer-template
+        label={t('Start (Longitude, Latitude)' + ': ')}

Review Comment:
   I guess this _could_ be a template string, but I don't particularly mind this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org