[GitHub] [superset] corbinrobb commented on a change in pull request #17758: feat(timeseries-chart): add percentage threshold input control

[GitBox <gi...@apache.org>]

corbinrobb commented on a change in pull request #17758:
URL: https://github.com/apache/superset/pull/17758#discussion_r782495198



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
##########
@@ -136,10 +136,29 @@ const onlyTotalControl = {
   },
 };
 
+const percentageThresholdControl = {
+  name: 'percentage_threshold',
+  config: {
+    type: 'TextControl',
+    label: t('Percentage threshold'),
+    renderTrigger: true,
+    isFloat: true,
+    default: 5,

Review comment:
       Ah yes, that is a bit confusing. What you got here makes a lot of sense. I will change it to this and push it up!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org