You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2010/07/21 14:53:49 UTC

[jira] Created: (KARAF-135) The package:export command should have more option to control the output

The package:export command should have more option to control the output
------------------------------------------------------------------------

                 Key: KARAF-135
                 URL: https://issues.apache.org/jira/browse/KARAF-135
             Project: Karaf
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Guillaume Nodet


The current output is not really easy to process or sort.
Having the symbolic name, maybe a clean column output, more like osgi:list maybe


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (KARAF-135) The package:export command should have more option to control the output

Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898815#action_12898815 ] 

Guillaume Nodet commented on KARAF-135:
---------------------------------------

A few problems with the patch you attached:
  * calling the packages:export command without any parameters lead to a NPE
  * the bundle ID and symbolic name are only shown for the first package for each bundle and the header line is repeated once for each bundle

See the output:
{code}
karaf@root> packages:exports -s 1 2 3
    ID Symbolic name                             Packages                                
     1 org.ops4j.pax.url.mvn                     org.ops4j.pax.url.mvn                   
    ID Symbolic name                             Packages                                
     2 org.ops4j.pax.url.wrap                    org.ops4j.pax.url.wrap                  
    ID Symbolic name                             Packages                                
     3 org.ops4j.pax.logging.pax-logging-api     org.apache.avalon.framework.logger      
                                                 org.apache.commons.logging              
                                                 org.apache.commons.logging              
                                                 org.apache.commons.logging.impl         
                                                 org.apache.commons.logging.impl         
                                                 org.apache.juli.logging                 
                                                 org.apache.log4j                        
                                                 org.apache.log4j.spi                    
                                                 org.apache.log4j.xml                    
                                                 org.knopflerfish.service.log            
                                                 org.ops4j.pax.logging                   
                                                 org.ops4j.pax.logging.avalon            
                                                 org.ops4j.pax.logging.slf4j             
                                                 org.osgi.service.log                    
                                                 org.slf4j                               
                                                 org.slf4j                               
                                                 org.slf4j.helpers                       
                                                 org.slf4j.helpers                       
                                                 org.slf4j.spi                           
                                                 org.slf4j.spi                           
{code}

> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>         Attachments: packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (KARAF-135) The package:export command should have more option to control the output

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos reassigned KARAF-135:
--------------------------------------

    Assignee: Ioannis Canellos

> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>            Assignee: Ioannis Canellos
>         Attachments: packages-export-patch.txt, packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (KARAF-135) The package:export command should have more option to control the output

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos updated KARAF-135:
-----------------------------------

    Attachment: packages-export-patch.txt

I am attaching an updated patch that

a) The Header line is displayed only once instead of once per bundle
b) Given no IDs the command displays the exported packages for ALL bundles.
c) The Master/Detail display is now optional (using the -d flag).

> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>         Attachments: packages-export-patch.txt, packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (KARAF-135) The package:export command should have more option to control the output

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos updated KARAF-135:
-----------------------------------

    Attachment: packages-export-patch.txt

I am attaching a patch the display the exported packages of a bundle in a (master/detail) table-like format .
The command now accepts the following arguments:

a) -i which displays as an additional column the bundles that import a package (Each bundle in a separate line with left justification).
b) -s which displays as an additional column the symbolic name of the bundle(s).

Note: The patch uses String format and each column has a maximum width of 40 chars.

> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>         Attachments: packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (KARAF-135) The package:export command should have more option to control the output

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901196#action_12901196 ] 

Ioannis Canellos commented on KARAF-135:
----------------------------------------

Regarding the first point I will look into it.
Regarding the second point, as I mention in my initial comment it is intended to work in a master/detail manner, so that the output is more easier to read (especially when using the -i flag).  

When displaying the bundles that import each package, the output is quite "overwhelming" unless it is displayed as master detail, so I would suggest that we either keep it this way or add an extra flag that would allow a master/detail output.

Please discuss.



> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>         Attachments: packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (KARAF-135) The package:export command should have more option to control the output

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos resolved KARAF-135.
------------------------------------

    Fix Version/s: 2.1.0
       Resolution: Fixed

Added a header and 2 additional parameters:
-s Symbolic Name 
-d Displays in a master / detail format.

Sending        packages/src/main/java/org/apache/karaf/shell/packages/ExportsCommand.java
Transmitting file data .Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)
Committed revision 996489.


> The package:export command should have more option to control the output
> ------------------------------------------------------------------------
>
>                 Key: KARAF-135
>                 URL: https://issues.apache.org/jira/browse/KARAF-135
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Guillaume Nodet
>            Assignee: Ioannis Canellos
>             Fix For: 2.1.0
>
>         Attachments: packages-export-patch.txt, packages-export-patch.txt
>
>
> The current output is not really easy to process or sort.
> Having the symbolic name, maybe a clean column output, more like osgi:list maybe

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.