You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ali Bazlamit <no...@github.com> on 2018/07/24 13:13:03 UTC
[jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules improvments
(#442)
https://issues.apache.org/jira/browse/JCLOUDS-1435
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/442
-- Commit Summary --
* Firewall Improvements
-- File Changes --
M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/FirewallPolicy.java (33)
M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/LoadBalancer.java (7)
M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Types.java (10)
M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/features/FirewallPolicyApi.java (6)
M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/features/ServerApi.java (7)
A oneandone/src/main/java/org/apache/jclouds/oneandone/rest/ids/ServerIpRef.java (31)
M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/FirewallPolicyApiLiveTest.java (35)
M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/FirewallPolicyApiMockTest.java (12)
M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/ServerApiMockTest.java (24)
M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/ServerNetworkApiLiveTest.java (77)
M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/internal/BaseOneAndOneLiveTest.java (54)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/442.patch
https://github.com/jclouds/jclouds-labs/pull/442.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ignasi Barrera <no...@github.com>.
Closed #442.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#event-1763379395
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ali Bazlamit <no...@github.com>.
@nacx It does not depend on any other PR's, could you just please take a look at the other 1&1 [PR](https://github.com/jclouds/jclouds-labs/pull/431). All issues were addressed in that PR yet it has been stalling for a while now.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#issuecomment-408834275
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ali Bazlamit <no...@github.com>.
@alibazlamit pushed 1 commit.
ef838fe Applied requested changes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442/files/7cdd0085ff9f1cba458d601dea32cf85fb746162..ef838fe636fbc4b49207b28862f63a4e04517d31
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.
Just one minor comment, otherwise LGTM. Does this PR depend on any other open PR?
> @@ -260,4 +260,14 @@ public static OSImageType fromValue(String v) {
}
}
+
+ public enum FirewallRuleAction {
+ allow,
+ deny,
+ UNRECOGNIZED;
Use the same case for all elements in the enum. All upper or all lower.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#pullrequestreview-141378843
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ignasi Barrera <no...@github.com>.
Squashed and merged to master as [d74d7f62](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d74d7f62). There were conflicts when cherry-picking to 2.1.x. If you want it backported there please, open a PR against that branch.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#issuecomment-409311388
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules
improvments (#442)
Posted by Ali Bazlamit <no...@github.com>.
@alibazlamit pushed 1 commit.
918c803 Applied requested changes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442/files/ef838fe636fbc4b49207b28862f63a4e04517d31..918c803ef7bd92ff8efa7afca279f4c1512824a6