You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Chang (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 02:10:32 UTC

[jira] [Created] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Consecutive string literals should be combined into a single string literal.
----------------------------------------------------------------------------

                 Key: HIVE-2527
                 URL: https://issues.apache.org/jira/browse/HIVE-2527
             Project: Hive
          Issue Type: Improvement
            Reporter: Jonathan Chang
            Assignee: Jonathan Chang
            Priority: Minor




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146041#comment-13146041 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

jonchang has committed the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

REVISION DETAIL
  https://reviews.facebook.net/D147

COMMIT
  https://reviews.facebook.net/rHIVE1199066

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141674#comment-13141674 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

jsichi has requested changes to the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

  ant test failed (see JIRA).


REVISION DETAIL
  https://reviews.facebook.net/D147

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141414#comment-13141414 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

jsichi has commented on the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:289 Might want to use StringBuilder here.

REVISION DETAIL
  https://reviews.facebook.net/D147

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2527:
------------------------------

    Attachment: D147.3.patch

jonchang updated the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".
Reviewers: JIRA, jsichi

  Use stringbuilder.

REVISION DETAIL
  https://reviews.facebook.net/D147

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/test/queries/clientpositive/literal_string.q
  ql/src/test/results/clientpositive/literal_string.q.out

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Chang updated HIVE-2527:
---------------------------------

    Attachment: D147.3.patch
    
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141664#comment-13141664 ] 

John Sichi commented on HIVE-2527:
----------------------------------

Got all kinds of failures, e.g. this one from dboutput.q in TestContribCliDriver:

{noformat}
    [junit] diff -a -I file: -I pfile: -I hdfs: -I /tmp/ -I invalidscheme: -I lastUp
dateTime -I lastAccessTime -I [Oo]wner -I CreateTime -I LastAccessTime -I Location -
I LOCATION ' -I transient_lastDdlTime -I last_modified_ -I java.lang.RuntimeExceptio
n -I at org -I at sun -I at java -I at junit -I Caused by: -I LOCK_QUERYID: -I LOCK_
TIME: -I grantTime -I [.][.][.] [0-9]* more -I job_[0-9]*_[0-9]* -I USING 'java -cp 
/data/users/jsichi/open/test-trunk/build/contrib/test/logs/contribclientpositive/dbo
utput.q.out /data/users/jsichi/open/test-trunk/contrib/src/test/results/clientpositi
ve/dboutput.q.out
    [junit] 48c48
    [junit] <   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) (TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION dboutpu
t (TOK_STRINGLITERALSEQUENCE 'jdbc:derby:../build/test_dboutput_db;create=true') (TO
K_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENC
E 'CREATE TABLE app_info ( kkey VARCHAR(255) NOT NULL, vvalue VARCHAR(255) NOT NULL,
 UNIQUE(kkey))'))) (TOK_SELEXPR (TOK_FUNCTION dboutput (TOK_STRINGLITERALSEQUENCE 'j
dbc:derby:../build/test_dboutput_db') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITE
RALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE 'INSERT INTO app_info (kkey,vvalue) VALUE
S (?,?)') (TOK_STRINGLITERALSEQUENCE '20') (TOK_STRINGLITERALSEQUENCE 'a'))) (TOK_SE
LEXPR (TOK_FUNCTION dboutput (TOK_STRINGLITERALSEQUENCE 'jdbc:derby:../build/test_db
output_db') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRIN
GLITERALSEQUENCE 'INSERT INTO app_info (kkey,vvalue) VALUES (?,?)') (TOK_STRINGLITER
ALSEQUENCE '20') (TOK_STRINGLITERALSEQUENCE 'b')))) (TOK_LIMIT 1)))
    [junit] ---
    [junit] >   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) (TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION dboutpu
t 'jdbc:derby:../build/test_dboutput_db;create=true' '' '' 'CREATE TABLE app_info ( 
kkey VARCHAR(255) NOT NULL, vvalue VARCHAR(255) NOT NULL, UNIQUE(kkey))')) (TOK_SELE
XPR (TOK_FUNCTION dboutput 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT INTO
 app_info (kkey,vvalue) VALUES (?,?)' '20' 'a')) (TOK_SELEXPR (TOK_FUNCTION dboutput
 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT INTO app_info (kkey,vvalue) VA
LUES (?,?)' '20' 'b'))) (TOK_LIMIT 1)))
    [junit] 129c129
    [junit] <   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) (TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION dboutpu
t (TOK_STRINGLITERALSEQUENCE 'jdbc:derby:../build/test_dboutput_db') (TOK_STRINGLITE
RALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE '') (TOK_STRINGLITERALSEQUENCE 'INSERT IN
TO app_info (kkey,vvalue) VALUES (?,?)') (TOK_TABLE_OR_COL key) (TOK_TABLE_OR_COL va
lue)))) (TOK_WHERE (< (TOK_TABLE_OR_COL key) 10))))
    [junit] ---
    [junit] >   (TOK_QUERY (TOK_FROM (TOK_TABREF (TOK_TABNAME src))) (TOK_INSERT (TO
K_DESTINATION (TOK_DIR TOK_TMP_FILE)) (TOK_SELECT (TOK_SELEXPR (TOK_FUNCTION dboutpu
t 'jdbc:derby:../build/test_dboutput_db' '' '' 'INSERT INTO app_info (kkey,vvalue) V
ALUES (?,?)' (TOK_TABLE_OR_COL key) (TOK_TABLE_OR_COL value)))) (TOK_WHERE (< (TOK_T
ABLE_OR_COL key) 10))))
    [junit] Exception: Client execution results failed with error code = 1
    [junit] See build/ql/tmp/hive.log, or try "ant test ... -Dtest.silent=false" to 
get more logs.
{noformat}



                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2527:
------------------------------

    Attachment: D147.4.patch

jonchang updated the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".
Reviewers: JIRA, jsichi

  Add both a StringLiteral and a stringLiteralSequence rule to minimize changes to parse trees.

REVISION DETAIL
  https://reviews.facebook.net/D147

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/test/queries/clientpositive/literal_string.q
  ql/src/test/results/clientpositive/literal_string.q.out

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141689#comment-13141689 ] 

John Sichi commented on HIVE-2527:
----------------------------------

I'll email it to you.  Some of them may be bogus due to side-effects from previous real failures.  But there's going to be a huge amount of diff from every existing string literal changing, so it might be better to figure out a way to make the rendering come out the same way as before.

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141325#comment-13141325 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

jonchang has planned changes to the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

  Will add unittest cases for akramer's case.

REVISION DETAIL
  https://reviews.facebook.net/D147

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146039#comment-13146039 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

jsichi has accepted the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

  Tests passed for me this time.

REVISION DETAIL
  https://reviews.facebook.net/D147

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Chang updated HIVE-2527:
---------------------------------

    Attachment: D147.4.patch
    
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146138#comment-13146138 ] 

Hudson commented on HIVE-2527:
------------------------------

Integrated in Hive-trunk-h0.21 #1066 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1066/])
    HIVE-2527 [jira] Consecutive string literals should be combined into a single
string literal.
(Jonathan Chang via jvs)

Summary:
HIVE

C, Python, etc. all support this magical feature.

Test Plan: EMPTY

Reviewers: JIRA, jsichi

Reviewed By: jsichi

CC: akramer, jonchang, jsichi

Differential Revision: 147

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199066
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
* /hive/trunk/ql/src/test/queries/clientpositive/literal_string.q
* /hive/trunk/ql/src/test/results/clientpositive/literal_string.q.out

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2527:
------------------------------

    Attachment: D147.2.patch

jonchang updated the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".
Reviewers: JIRA, jsichi

  More unittest cases.

REVISION DETAIL
  https://reviews.facebook.net/D147

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/test/queries/clientpositive/literal_string.q
  ql/src/test/results/clientpositive/literal_string.q.out

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Jonathan Chang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141675#comment-13141675 ] 

Jonathan Chang commented on HIVE-2527:
--------------------------------------

This just looks like a complaint about the parse trees changing.  Do you have the full list of failures?
                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2527:
------------------------------

    Attachment: D147.1.patch

jonchang requested code review of "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".
Reviewers: JIRA

  HIVE

  C, Python, etc. all support this magical feature.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D147

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/test/queries/clientpositive/literal_string.q
  ql/src/test/results/clientpositive/literal_string.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/309/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141023#comment-13141023 ] 

Phabricator commented on HIVE-2527:
-----------------------------------

akramer has commented on the revision "HIVE-2527 [jira] Consecutive string literals should be combined into a single string literal.".

INLINE COMMENTS
  ql/src/test/queries/clientpositive/literal_string.q:1 But what about 'face'"book"?

REVISION DETAIL
  https://reviews.facebook.net/D147

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145784#comment-13145784 ] 

John Sichi commented on HIVE-2527:
----------------------------------

I'll rerun tests with latest.

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "John Sichi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141477#comment-13141477 ] 

John Sichi commented on HIVE-2527:
----------------------------------

+1.  Will commit when tests pass.

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "John Sichi (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi resolved HIVE-2527.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.0
     Hadoop Flags: Reviewed

Committed to trunk.  Thanks Jonathan!

Can you reattach the last patch with ASF grant?

                
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: D147.1.patch, D147.2.patch, D147.3.patch, D147.3.patch, D147.4.patch
>
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2527) Consecutive string literals should be combined into a single string literal.

Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Chang updated HIVE-2527:
---------------------------------

    Description: C, Python, etc. all support this magical feature.
    
> Consecutive string literals should be combined into a single string literal.
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2527
>                 URL: https://issues.apache.org/jira/browse/HIVE-2527
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>            Priority: Minor
>
> C, Python, etc. all support this magical feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira