[jira] [Commented] (HDFS-16149) Improve the parameter annotation in FairCallQueue#priorityLevels

["JiangHua Zhu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-16149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391454#comment-17391454 ] 

JiangHua Zhu commented on HDFS-16149:
-------------------------------------

[~weichiu], [~hexiaoqiao]e, I look forward to your review of the code I submitted. If there are any imperfections, I am willing to make more contributions.
thank you very much.


> Improve the parameter annotation in FairCallQueue#priorityLevels
> ----------------------------------------------------------------
>
>                 Key: HDFS-16149
>                 URL: https://issues.apache.org/jira/browse/HDFS-16149
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: JiangHua Zhu
>            Assignee: JiangHua Zhu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The parameter description of FairCallQueue#priorityLevels is missing in FairCallQueue.
>    /**
>     * Create a FairCallQueue.
>     * @param capacity the total size of all sub-queues
>     * @param ns the prefix to use for configuration
>     * @param capacityWeights the weights array for capacity allocation
>     * among subqueues
>     * @param conf the configuration to read from
>     * Notes: Each sub-queue has a capacity of `capacity / numSubqueues`.
>     * The first or the highest priority sub-queue has an excess capacity
>     * of `capacity% numSubqueues`
>     */
>    public FairCallQueue(int priorityLevels, int capacity, String ns,
>        int[] capacityWeights, Configuration conf) {
> We should be more perfect for them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org