You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/12 19:31:47 UTC
Review Request 71273: Fixed a flaky test
`RescindOffersEnforcingLimits`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71273/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Bugs: MESOS-9922
https://issues.apache.org/jira/browse/MESOS-9922
Repository: mesos
Description
-------
The test is flaky because the agent is added before the
framework and agent is not offered the framework as expected.
This patch ensures that the framework is added before the agent.
Diffs
-----
src/tests/master_quota_tests.cpp b5fe2350569271e3214cedf3300ac3f0fb34e01e
Diff: https://reviews.apache.org/r/71273/diff/1/
Testing
-------
make check
ran test repeatedly without failure
Thanks,
Meng Zhu
Re: Review Request 71273: Fixed a flaky test
`RescindOffersEnforcingLimits`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71273/#review217160
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 12, 2019, 7:31 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71273/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2019, 7:31 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Bugs: MESOS-9922
> https://issues.apache.org/jira/browse/MESOS-9922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky because the agent is added before the
> framework and agent is not offered the framework as expected.
> This patch ensures that the framework is added before the agent.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp b5fe2350569271e3214cedf3300ac3f0fb34e01e
>
>
> Diff: https://reviews.apache.org/r/71273/diff/1/
>
>
> Testing
> -------
>
> make check
> ran test repeatedly without failure
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71273: Fixed a flaky test
`RescindOffersEnforcingLimits`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71273/#review217162
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71273]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 12, 2019, 7:31 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71273/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2019, 7:31 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Bugs: MESOS-9922
> https://issues.apache.org/jira/browse/MESOS-9922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test is flaky because the agent is added before the
> framework and agent is not offered the framework as expected.
> This patch ensures that the framework is added before the agent.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp b5fe2350569271e3214cedf3300ac3f0fb34e01e
>
>
> Diff: https://reviews.apache.org/r/71273/diff/1/
>
>
> Testing
> -------
>
> make check
> ran test repeatedly without failure
>
>
> Thanks,
>
> Meng Zhu
>
>