You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/11/07 01:30:37 UTC
Review Request 27712: Fixing beta-update OK status messaging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-784
https://issues.apache.org/jira/browse/AURORA-784
Repository: aurora
Description
-------
Fixing beta-update OK status messaging:
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job update has started.
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job is unchanged by proposed update.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
Diff: https://reviews.apache.org/r/27712/diff/
Testing
-------
./gradlew -Pq build
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/#review60363
-----------------------------------------------------------
Ship it!
Master (2d68bc6) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 7, 2014, 7:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27712/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 7:13 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-784
> https://issues.apache.org/jira/browse/AURORA-784
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing beta-update OK status messaging:
>
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job update has started.
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job is unchanged by proposed update.
> vagrant@192:~$ aurora2 beta-update pause devcluster/www-data/prod/hello
> Update has been paused.
> vagrant@192:~$ aurora2 beta-update resume devcluster/www-data/prod/hello
> Update has been resumed.
> vagrant@192:~$ aurora2 beta-update abort devcluster/www-data/prod/hello
> Update has been aborted.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
> src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
> src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
> src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
> src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
> src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
>
> Diff: https://reviews.apache.org/r/27712/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 7:13 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-784
https://issues.apache.org/jira/browse/AURORA-784
Repository: aurora
Description
-------
Fixing beta-update OK status messaging:
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job update has started.
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job is unchanged by proposed update.
vagrant@192:~$ aurora2 beta-update pause devcluster/www-data/prod/hello
Update has been paused.
vagrant@192:~$ aurora2 beta-update resume devcluster/www-data/prod/hello
Update has been resumed.
vagrant@192:~$ aurora2 beta-update abort devcluster/www-data/prod/hello
Update has been aborted.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
Diff: https://reviews.apache.org/r/27712/diff/
Testing
-------
./gradlew -Pq build
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 7:12 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-784
https://issues.apache.org/jira/browse/AURORA-784
Repository: aurora
Description (updated)
-------
Fixing beta-update OK status messaging:
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job update has started.
vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
Job is unchanged by proposed update.
vagrant@192:~$ aurora2 beta-update pause devcluster/www-data/prod/hello
Update has been paused.
vagrant@192:~$ aurora2 beta-update resume devcluster/www-data/prod/hello
Update has been resumed.
vagrant@192:~$ aurora2 beta-update abort devcluster/www-data/prod/hello
Update has been aborted.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
Diff: https://reviews.apache.org/r/27712/diff/
Testing
-------
./gradlew -Pq build
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Nov. 7, 2014, 6:05 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1582
> > <https://reviews.apache.org/r/27712/diff/1/?file=754027#file754027line1582>
> >
> > Please remove. The API really should not be sending back messages of the form "i did what you asked me to do." Sticking strictly to only including a response message when it is necessary allows us to have a client that is not overly-chatty.
That was simplifying client handling a bit but I see your point. Changed.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/#review60352
-----------------------------------------------------------
On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27712/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 12:30 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-784
> https://issues.apache.org/jira/browse/AURORA-784
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing beta-update OK status messaging:
>
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job update has started.
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job is unchanged by proposed update.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
> src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
> src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
> src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
> src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
> src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
>
> Diff: https://reviews.apache.org/r/27712/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/#review60352
-----------------------------------------------------------
Ship it!
LGTM once "Job update has started" message is removed from the API response.
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/27712/#comment101715>
Please remove. The API really should not be sending back messages of the form "i did what you asked me to do." Sticking strictly to only including a response message when it is necessary allows us to have a client that is not overly-chatty.
- Bill Farner
On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27712/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 12:30 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-784
> https://issues.apache.org/jira/browse/AURORA-784
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing beta-update OK status messaging:
>
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job update has started.
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job is unchanged by proposed update.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
> src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
> src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
> src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
> src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
> src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
>
> Diff: https://reviews.apache.org/r/27712/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27712: Fixing beta-update OK status messaging.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27712/#review60282
-----------------------------------------------------------
Ship it!
Master (5250a94) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27712/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 12:30 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-784
> https://issues.apache.org/jira/browse/AURORA-784
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing beta-update OK status messaging:
>
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job update has started.
> vagrant@192:~$ aurora2 beta-update start devcluster/www-data/prod/hello aurora/examples/jobs/hello_world.aurora
> Job is unchanged by proposed update.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 175bba24a11587a4c0c595588a01f9e6503442fc
> src/main/python/apache/aurora/client/cli/context.py 0a3c2236916f52919b48e9254929c2fbe9eb5252
> src/main/python/apache/aurora/client/cli/jobs.py b4d9360ed71953e5733e4bc0ba8acaaf01cf6da0
> src/main/python/apache/aurora/client/cli/quota.py 3130bfbaca994fb9b8c8f0eb9d32b284fd6e6ce2
> src/main/python/apache/aurora/client/cli/update.py 0797e30bb40eb983a5ba2f47d1e1955049fb345a
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b42f6e2d23eb44605cc84ce01a80f10344a7e43f
> src/test/python/apache/aurora/client/cli/test_supdate.py 8943f8c1a5809c197d5d1f3dd6f24999f0dfe359
>
> Diff: https://reviews.apache.org/r/27712/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/tests/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>