You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/04 17:34:43 UTC

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7629: GEODE-7875: fix create index gfsh command on partitioned region

jinmeiliao commented on code in PR #7629:
URL: https://github.com/apache/geode/pull/7629#discussion_r865101775


##########
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateIndexCommand.java:
##########
@@ -96,7 +96,7 @@ public ResultModel createIndex(@CliOption(key = CliStrings.CREATE_INDEX__NAME, m
             .createError("Region " + regionName + " does not exist in some of the groups.");
       }
       if (groups == null) {

Review Comment:
   I would recommend putting the determination of member for the partition region here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org