You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2025/12/22 06:28:20 UTC
(spark) branch branch-4.1 updated: [SPARK-52407][SQL][FOLLOWUP] Expression description fix for ThetaIntersectionAgg
This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch branch-4.1
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.1 by this push:
new 8352e3a0a301 [SPARK-52407][SQL][FOLLOWUP] Expression description fix for ThetaIntersectionAgg
8352e3a0a301 is described below
commit 8352e3a0a301369b52af7beafcb1fd2f5645668b
Author: Chris Boumalhab <cb...@amazon.com>
AuthorDate: Mon Dec 22 14:27:40 2025 +0800
[SPARK-52407][SQL][FOLLOWUP] Expression description fix for ThetaIntersectionAgg
### What changes were proposed in this pull request?
This PR corrects the ExpressionDescription usage text for theta_intersection_agg function. The usage description was updated from:
`_FUNC_(expr, lgNomEntries)`
to:
`_FUNC_(expr)`
### Why are the changes needed?
The previous documentation incorrectly showed lgNomEntries as a parameter for theta_intersection_agg. This function only accepts a single expression parameter, unlike theta_sketch_agg and theta_union_agg which both accept an optional lgNomEntries parameter. This change ensures the documentation accurately reflects the function's signature and provides a clearer description of what the function does.
### Does this PR introduce _any_ user-facing change?
Yes - the documentation shown in SQL help/describe function output for theta_intersection_agg will now correctly show only one parameter instead of two, and will include a more descriptive explanation of the function's behavior.
### How was this patch tested?
The change is documentation-only. The function signature and implementation remain unchanged. Existing tests for theta_intersection_agg continue to validate the correct behavior.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #53552 from cboumalh/cboumalh-theta-followup.
Authored-by: Chris Boumalhab <cb...@amazon.com>
Signed-off-by: Wenchen Fan <we...@databricks.com>
(cherry picked from commit e4b75089034b7a735f0f6baafe26d4f6a782a52a)
Signed-off-by: Wenchen Fan <we...@databricks.com>
---
.../sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala
index f841632b1462..a14df39bf822 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/thetasketchesAggregates.scala
@@ -497,7 +497,7 @@ case class ThetaUnionAgg(
// scalastyle:off line.size.limit
@ExpressionDescription(
usage = """
- _FUNC_(expr, lgNomEntries) - Returns the ThetaSketch's Compact binary representation
+ _FUNC_(expr) - Returns the ThetaSketch's Compact binary representation
by intersecting all the Theta sketches in the input column.""",
examples = """
Examples:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org