[jira] [Work logged] (BEAM-12849) Structured Streaming runner: Migrate metrics sources

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12849?focusedWorklogId=658810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658810 ]

ASF GitHub Bot logged work on BEAM-12849:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/21 08:17
            Start Date: 01/Oct/21 08:17
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on a change in pull request #15529:
URL: https://github.com/apache/beam/pull/15529#discussion_r719126109



##########
File path: runners/spark/spark_runner.gradle
##########
@@ -166,6 +166,10 @@ dependencies {
   provided "org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
   provided "org.apache.spark:spark-sql_$spark_scala_version:$spark_version"
   provided "org.apache.spark:spark-streaming_$spark_scala_version:$spark_version"
+  runtimeOnly "org.apache.spark:spark-core_$spark_scala_version:$spark_version"

Review comment:
       > 1. Why do we need to have two configurations (`provided` and `runtimeOnly`) for the same deps?
   > 2. Can you make sure that generated jars won't cause breaking changes for users who already use any of Spark Runners?
   
   1. because provided scope is given by a gradle plugin and is not equivalent to maven provided scope, it lacks putting the libs in the runtime classpath. The libs are needed in the runtime classpath for local in memory runs for example Nexmark. In gradle we can extend the scopes by adding multiple scope lines.
   2. Like I said in the description of the PR I checked that the generated jars do not contain apache spark libs.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 658810)
    Time Spent: 3h 40m  (was: 3.5h)

> Structured Streaming runner: Migrate metrics sources
> ----------------------------------------------------
>
>                 Key: BEAM-12849
>                 URL: https://issues.apache.org/jira/browse/BEAM-12849
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: P2
>              Labels: structured-streaming
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> java.lang.ClassNotFoundException: org.apache.spark.metrics.source.Source no more exists in spark 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)