You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/01 15:23:11 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6516: Move `physical_plan::file_format` to `datasource::plan`

alamb opened a new pull request, #6516:
URL: https://github.com/apache/arrow-datafusion/pull/6516

   # Which issue does this PR close?
   
   This is part of https://github.com/apache/arrow-datafusion/issues/1754
   
   # Rationale for this change
   
   While trying to extract `physical_plan` out of the core datafusion crate, the implementation of the various formats need to instantiate `ExecutionPlan`s (e.g. `ParquetExec`) -- so therefore I conclude I need to remove the dependency out of physical_plan
   
   # What changes are included in this PR?
   
   1. Move `physical_plan::file_format` to `datasource::plan`
   
   # Are these changes tested?
   Existing tests
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   3. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   Yes, this does change the import path for anyone who uses structures like `ParquetExec`, etc 
   
   I would be open to other suggestions too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6516: Move `physical_plan::file_format` to `datasource::plan`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6516:
URL: https://github.com/apache/arrow-datafusion/pull/6516#issuecomment-1579467668

   Since this has a substantial chance of conflicts I am going to merge it in now to avoid them as much as possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6516: Move `physical_plan::file_format` to `datasource::plan`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6516:
URL: https://github.com/apache/arrow-datafusion/pull/6516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6516: RFC: Move `physical_plan::file_format` to `datasource::plan`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6516:
URL: https://github.com/apache/arrow-datafusion/pull/6516#issuecomment-1577486782

   After a bunch of thought, I am convinced this is the right next step towards splitting out physical plan 
   
   Thus I plan to update and merge this PR after https://github.com/apache/arrow-datafusion/pull/6526 from @mustafasrepo is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6516: Move `physical_plan::file_format` to `datasource::plan`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6516:
URL: https://github.com/apache/arrow-datafusion/pull/6516#issuecomment-1577488952

   I think after this PR I can move physical_plan out of datafusion core
   
   I will then work on extracting datafusion_physical_optimizer out as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org