[GitHub] [airflow] uranusjr commented on pull request #22004: Add map_index to RenderedTaskInstanceFields

[GitBox <gi...@apache.org>]

uranusjr commented on pull request #22004:
URL: https://github.com/apache/airflow/pull/22004#issuecomment-1062674787


   > I'm thinking we should add a mapped_value JSON column here in this migration. When does the mapped value become available?
   
   They are populated when XCom is resolved, and should be available when RenderedTaskInstanceFields are written. However, since a RenderedTaskInstanceFields row maps to a TaskInstance row, I think we should simply resolve the mapped values directly instead.
   
   On UI we should also add a marker to indicate a particular field value is mapped, so perhaps add a field to record the field _names_. Or maybe even this is unnecessary since this information is available on the task object? Or maybe in some scenarios we want to read RenderedTaskInstanceFields without parsing the DAG? (Currently I can only find this being used in `/rendered-k8s` and `/rendered-templates`, and in both views we already fetch the original task object and know what fields are mapped anyway.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org