You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/19 23:50:43 UTC
Re: Review Request 61096: Building gRPC with CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated March 19, 2018, 11:50 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Summary (updated)
-----------------
Building gRPC with CMake.
Bugs: MESOS-7808
https://issues.apache.org/jira/browse/MESOS-7808
Repository: mesos
Description (updated)
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099
cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/5/
Changes: https://reviews.apache.org/r/61096/diff/4-5/
Testing (updated)
-------
`sudo make check` with CMake
NOTE: Testing on Windowns is not done yet.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On April 12, 2018, 9:41 a.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 1012-1015 (patched)
> > <https://reviews.apache.org/r/61096/diff/6/?file=1996892#file1996892line1014>
> >
> > As stated above, the probably won't work on Windows yet. Ths VS solutions generally stick everything under `Debug` or `Release` folders, and it's done at build time, not configuration time. It's super annoying.
>
> Chun-Hung Hsiao wrote:
> Temporarily disable the WIN32 build. Can you help me on this since I don't have an available Windows machine to test the build? :(
That's fine, default it to disabled, add a TODO, and file an issue. We'll get back to it after 1.6.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201007
-----------------------------------------------------------
On April 16, 2018, 8:16 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 8:16 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
> 3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2
> cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/7/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
> NOTE: Testing on Windowns is not done yet.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On April 12, 2018, 4:41 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Line 143 (original), 144-145 (patched)
> > <https://reviews.apache.org/r/61096/diff/6/?file=1996892#file1996892line144>
> >
> > Seems reasonable. Could alternatively setup `ENABLE_GRPC` to set `ENABLE_SSL` (and therefore also `libevent`?)
As discussed, now I only build `gpr`, `grpc_cpp_plugin`, and `grpc++_unsecure` and `grpc_unsecure` or `grpc++` and `grpc` depending on whether `ENABLE_SSL` is on.
> On April 12, 2018, 4:41 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 1012-1015 (patched)
> > <https://reviews.apache.org/r/61096/diff/6/?file=1996892#file1996892line1014>
> >
> > As stated above, the probably won't work on Windows yet. Ths VS solutions generally stick everything under `Debug` or `Release` folders, and it's done at build time, not configuration time. It's super annoying.
Temporarily disable the WIN32 build. Can you help me on this since I don't have an available Windows machine to test the build? :(
> On April 12, 2018, 4:41 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 1022-1027 (patched)
> > <https://reviews.apache.org/r/61096/diff/6/?file=1996892#file1996892line1024>
> >
> > Do you want the `C` or `CXX` flags forwarded too?
Thanks for pointing this out. Actually it's not only the flags, but the compiler themselves should be forwarded as well.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201007
-----------------------------------------------------------
On April 12, 2018, 3:22 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 12, 2018, 3:22 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
> 3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099
> cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/6/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
> NOTE: Testing on Windowns is not done yet.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201007
-----------------------------------------------------------
I want to test on Windows and see if we can get it building there too before giving it a ship-it, but this looks good!
3rdparty/CMakeLists.txt
Line 143 (original), 144-145 (patched)
<https://reviews.apache.org/r/61096/#comment281940>
Seems reasonable. Could alternatively setup `ENABLE_GRPC` to set `ENABLE_SSL` (and therefore also `libevent`?)
3rdparty/CMakeLists.txt
Lines 1012-1015 (patched)
<https://reviews.apache.org/r/61096/#comment281941>
As stated above, the probably won't work on Windows yet. Ths VS solutions generally stick everything under `Debug` or `Release` folders, and it's done at build time, not configuration time. It's super annoying.
3rdparty/CMakeLists.txt
Lines 1022-1027 (patched)
<https://reviews.apache.org/r/61096/#comment281942>
Do you want the `C` or `CXX` flags forwarded too?
- Andrew Schwartzmeyer
On April 11, 2018, 8:22 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 8:22 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
> 3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099
> cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/6/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
> NOTE: Testing on Windowns is not done yet.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201662
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On April 20, 2018, 3:18 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 3:18 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
> 3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
> cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/12/
>
>
> Testing
> -------
>
> `cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
>
> NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 20, 2018, 10:18 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Addressed a VS builed problem.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/12/
Changes: https://reviews.apache.org/r/61096/diff/11-12/
Testing
-------
`cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 20, 2018, 9:51 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Unified the build command for gRPC.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/11/
Changes: https://reviews.apache.org/r/61096/diff/10-11/
Testing
-------
`cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 20, 2018, 9:22 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Fixed a Ninja build problem.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/10/
Changes: https://reviews.apache.org/r/61096/diff/9-10/
Testing
-------
`cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the next patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201623
-----------------------------------------------------------
This does currently not configure for me with `ENABLE_GRPC` (for the Ninja generator):
CMake Error at 3rdparty/CMakeLists.txt:177 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "IMPORTED_LOCATION" is not allowed.
Call Stack (most recent call first):
3rdparty/CMakeLists.txt:1112 (GET_BYPRODUCTS)
- Benjamin Bannier
On April 20, 2018, 4:28 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 4:28 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
> 3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
> cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/9/
>
>
> Testing
> -------
>
> `cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
>
> NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the next patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 20, 2018, 2:28 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Enabled Windows build.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9
3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30
cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/8/
Changes: https://reviews.apache.org/r/61096/diff/7-8/
Testing (updated)
-------
`cmake .. -DENABLE_GRPC=1` on both Linux and Windows.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On April 18, 2018, 6:57 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 1001 (patched)
> > <https://reviews.apache.org/r/61096/diff/7/?file=2003265#file2003265line1001>
> >
> > I see `gpr` in here which looks like a typo for `grp`?
No. It's GPR, a library used in grpc core: https://github.com/grpc/grpc/blob/master/src/core/lib/gpr/README.md
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201443
-----------------------------------------------------------
On April 17, 2018, 3:16 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 17, 2018, 3:16 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
> 3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2
> cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/7/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
> NOTE: Testing on Windowns is not done yet.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201443
-----------------------------------------------------------
3rdparty/CMakeLists.txt
Lines 1001 (patched)
<https://reviews.apache.org/r/61096/#comment282681>
I see `gpr` in here which looks like a typo for `grp`?
- Andrew Schwartzmeyer
On April 16, 2018, 8:16 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 8:16 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
> 3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2
> cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d
> src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
>
>
> Diff: https://reviews.apache.org/r/61096/diff/7/
>
>
> Testing
> -------
>
> `sudo make check` with CMake
>
> NOTE: Testing on Windowns is not done yet.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 17, 2018, 3:16 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Andy's comments.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
3rdparty/cmake/Versions.cmake 605cbdebe2518c234a55921dc07443546ec045e2
cmake/CompilationConfigure.cmake 08d154e6e4b718b6059afb70e0b0235d1725d72d
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/7/
Changes: https://reviews.apache.org/r/61096/diff/6-7/
Testing
-------
`sudo make check` with CMake
NOTE: Testing on Windowns is not done yet.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61096: Building gRPC with CMake.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
-----------------------------------------------------------
(Updated April 12, 2018, 3:22 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881
Repository: mesos
Description
-------
This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99
3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099
cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c
src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc
Diff: https://reviews.apache.org/r/61096/diff/6/
Changes: https://reviews.apache.org/r/61096/diff/5-6/
Testing
-------
`sudo make check` with CMake
NOTE: Testing on Windowns is not done yet.
Thanks,
Chun-Hung Hsiao