You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/14 12:33:30 UTC

[GitHub] [arrow] rok commented on pull request #12154: ARROW-14281: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

rok commented on pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#issuecomment-1013080010


   This looks great @djnavarro thanks for doing it!
   
   Regarding your TODOs:
   
   > support week_start (essential)
   
   Perhaps you can put in an R shim to get lubridate matching logic and open a Jira to fix this in c++ later on.
   
   > support timezones correctly (essential)
   
   I found dates around 1900s quite problematic when testing against Pandas as they don't apply some historic offset changes. I'd suggest aiming at more modern times first.
   
   > support change_on_boundary argument to ceiling_date
   
   This would probably be a good c++ Jira candidate too. Provide some examples if you have them handy :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org