svn commit: r1747835 - /poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java

[on...@apache.org]

Author: onealj
Date: Sat Jun 11 01:41:54 2016
New Revision: 1747835

URL: http://svn.apache.org/viewvc?rev=1747835&view=rev
Log:
add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names

Modified:
    poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java?rev=1747835&r1=1747834&r2=1747835&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java Sat Jun 11 01:41:54 2016
@@ -71,6 +71,7 @@ public final class AnalysisToolPak imple
         // if you save such a .xlsx workbook as .xls
         if(name.startsWith("_xlfn.")) name = name.substring(6);
 
+        // FIXME: inconsistent case-sensitivity
         return _functionsByName.get(name.toUpperCase(Locale.ROOT));
     }
 
@@ -197,6 +198,7 @@ public final class AnalysisToolPak imple
 
     public static boolean isATPFunction(String name){
         AnalysisToolPak inst = (AnalysisToolPak)instance;
+        // FIXME: inconsistent case-sensitivity
         return inst._functionsByName.containsKey(name);
     }
 
@@ -261,6 +263,7 @@ public final class AnalysisToolPak imple
                     ". You cannot override POI's implementations of Excel functions");
         }
 
+        // FIXME: inconsistent case-sensitivity
         inst._functionsByName.put(name, func);
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org