[GitHub] [avro] mparry commented on a diff in pull request #2270: AVRO-2397: [c++] Add support for type and field aliases

["mparry (via GitHub)" <gi...@apache.org>]

mparry commented on code in PR #2270:
URL: https://github.com/apache/avro/pull/2270#discussion_r1221377018


##########
lang/c++/api/Node.hh:
##########
@@ -40,30 +40,38 @@ class GenericDatum;
 using NodePtr = std::shared_ptr<Node>;
 
 class AVRO_DECL Name {
+    struct Aliases;
+
     std::string ns_;
     std::string simpleName_;
+    std::unique_ptr<Aliases> aliases_;

Review Comment:
   @martin-g - if you could approve the workflows again, the tests should pass this time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org