You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/12 11:24:36 UTC
[GitHub] [activemq-artemis] cenitfish opened a new pull request #3576: NO-JIRA artemis.data system property
cenitfish opened a new pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576
Within the artemis.xml the locations for storing the data can be configured (paging-directory, bindings-directory, journal-directory, large-messages-directory). Would it be possible to additionally support the system property artemis.data? The configuration would then be much easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-842719960
JIRA? Whilst code implementation is small this clearly is a new feature/capability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-842719960
Could this get a JIRA, and the commit updated to include it. Whilst code implementation is small this clearly is a new feature/capability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-839792260
this is just renaming karat.data property as artemis.data right?
I just realized that the context of your change is OSGI only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] cenitfish commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
cenitfish commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-842133500
I did and thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-841235098
ok.. fine with me...
Can you create a JIRA, and then:
```
git commit -a --amend
```
edit your NO-JIRA with the JIRA
```
git push -f
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-842720598
Ok ignore my last comment i see commit is with Jira, maybe just update the PR name too ;) as this is what i picked up on quickly reviewing backlog of PR's i havent put my eyes on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-842719960
JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] cenitfish commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
cenitfish commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-839797439
And yes we work with Apache Karaf OSGi environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-839722660
Sure we can do that.
But artemis.instance was meant for that already. What would be the use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] cenitfish commented on pull request #3576: NO-JIRA artemis.data system property
Posted by GitBox <gi...@apache.org>.
cenitfish commented on pull request #3576:
URL: https://github.com/apache/activemq-artemis/pull/3576#issuecomment-839796283
Simply renaming karaf.data to artemis.data would also suffice for our purposes. In the meantime I tried the system property artemis.instance, but without success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org