You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/09/09 08:32:14 UTC
Review Request 38209: Sqoop2: Provide List type for configuration
objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38209/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2462
https://issues.apache.org/jira/browse/SQOOP-2462
Repository: sqoop-sqoop2
Description
-------
While doing some changes inside JDBC Connector I came to a need of List type in addition to the existing Map that we have. After having discussion with Jonathan Seidman that is working on (S)FTP connectors he mentioned the same need, so I'm creating this JIRA
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 0d40715
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java b4146a7
common/src/main/java/org/apache/sqoop/model/MConfig.java 9e12979
common/src/main/java/org/apache/sqoop/model/MConfigList.java d09434a
common/src/main/java/org/apache/sqoop/model/MInputType.java 7e6b90a
common/src/main/java/org/apache/sqoop/model/MListInput.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java d2989d3
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 2b47c13
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 3dfc33a
common/src/test/java/org/apache/sqoop/model/TestMListInput.java PRE-CREATION
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46235be
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 6540a52
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 8b5f380
Diff: https://reviews.apache.org/r/38209/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 38209: Sqoop2: Provide List type for configuration
objects
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38209/#review98173
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 9, 2015, 7:54 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38209/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:54 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2462
> https://issues.apache.org/jira/browse/SQOOP-2462
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> While doing some changes inside JDBC Connector I came to a need of List type in addition to the existing Map that we have. After having discussion with Jonathan Seidman that is working on (S)FTP connectors he mentioned the same need, so I'm creating this JIRA
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 0d40715
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java b4146a7
> common/src/main/java/org/apache/sqoop/model/MConfig.java 9e12979
> common/src/main/java/org/apache/sqoop/model/MConfigList.java d09434a
> common/src/main/java/org/apache/sqoop/model/MInputType.java 7e6b90a
> common/src/main/java/org/apache/sqoop/model/MListInput.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java d2989d3
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java 2b47c13
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 3dfc33a
> common/src/test/java/org/apache/sqoop/model/TestMListInput.java PRE-CREATION
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46235be
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 6540a52
> shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 8b5f380
>
> Diff: https://reviews.apache.org/r/38209/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38209: Sqoop2: Provide List type for configuration
objects
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38209/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 7:54 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2462
https://issues.apache.org/jira/browse/SQOOP-2462
Repository: sqoop-sqoop2
Description
-------
While doing some changes inside JDBC Connector I came to a need of List type in addition to the existing Map that we have. After having discussion with Jonathan Seidman that is working on (S)FTP connectors he mentioned the same need, so I'm creating this JIRA
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 0d40715
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java b4146a7
common/src/main/java/org/apache/sqoop/model/MConfig.java 9e12979
common/src/main/java/org/apache/sqoop/model/MConfigList.java d09434a
common/src/main/java/org/apache/sqoop/model/MInputType.java 7e6b90a
common/src/main/java/org/apache/sqoop/model/MListInput.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java d2989d3
common/src/test/java/org/apache/sqoop/model/TestMConfig.java 2b47c13
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 3dfc33a
common/src/test/java/org/apache/sqoop/model/TestMListInput.java PRE-CREATION
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46235be
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 6540a52
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 8b5f380
Diff: https://reviews.apache.org/r/38209/diff/
Testing
-------
Thanks,
Dian Fu