You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/03/08 19:00:34 UTC
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/105
Fix dispatch to handle_error EPI hook
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-chttpd fix/handle_error-hook
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 79677f8a9f0748df0a266f9412d3385d020d2fb1
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2016-03-08T17:59:38Z
Fix dispatch to handle_error EPI hook
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193895613
I think it's a copy-paste fix of wrong hook usage to catch the errors over epi.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193907666
those Russian devs, they never answer, just gloomy carry on :guardsman:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193897222
Ah, ok, so this is so the plugins get called on `handle_error` callback with chttpd's errors instead of `after_request`, if I read code correctly.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-194340198
@eiri: I thought that you were satisfied with @kxepal explanation. You also provided a correct explanation yourself here https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193897222. Going forward I will provide a short explanations for PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193894417
Just a short note on what it does, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-193932138
@eiri
In Soviet Russia only KGB can get the answers from you! P:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Fix dispatch to handle_error EPI hook
Posted by eiri <gi...@git.apache.org>.
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/105#issuecomment-194354682
@iilyak cool, thank you! sorry for been grumpy, it just I've spent so much time in git's blame on mrview, trying to understand _whys_, that I came to really value a good explanation on PR and always trying to do that for sake of some poor soul that'd come to look at my code in five years.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---