You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "duncangrant (via GitHub)" <gi...@apache.org> on 2024/01/25 21:50:30 UTC

[PR] Updated licenses [brooklyn-dist]

duncangrant opened a new pull request, #184:
URL: https://github.com/apache/brooklyn-dist/pull/184

   Updated licences ahead of release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated licenses [brooklyn-dist]

Posted by "jcabrerizo (via GitHub)" <gi...@apache.org>.
jcabrerizo commented on code in PR #184:
URL: https://github.com/apache/brooklyn-dist/pull/184#discussion_r1467295306


##########
karaf/features/src/main/resources/resources/NOTICE:
##########
@@ -146,9 +146,15 @@ Bundled dependencies:
     License name: MIT License
     Notice:       Copyright (c) 2011-2016 Twitter, Inc.
   
-  ch.qos.logback:1.2.3: 
+  ch.qos.logback:0.1.5: 

Review Comment:
   I'm curious where this version is coming from.
   Brooklyn uses `1.2.9` I suppose it's a new transient dependency, but it seems very old.
   
   It could be also a glitch in the license scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated licenses [brooklyn-dist]

Posted by "jcabrerizo (via GitHub)" <gi...@apache.org>.
jcabrerizo merged PR #184:
URL: https://github.com/apache/brooklyn-dist/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated licenses [brooklyn-dist]

Posted by "jcabrerizo (via GitHub)" <gi...@apache.org>.
jcabrerizo commented on code in PR #184:
URL: https://github.com/apache/brooklyn-dist/pull/184#discussion_r1467413675


##########
karaf/features/src/main/resources/resources/NOTICE:
##########
@@ -146,9 +146,15 @@ Bundled dependencies:
     License name: MIT License
     Notice:       Copyright (c) 2011-2016 Twitter, Inc.
   
-  ch.qos.logback:1.2.3: 
+  ch.qos.logback:0.1.5: 

Review Comment:
   Thanks for the clarification! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Updated licenses [brooklyn-dist]

Posted by "duncangrant (via GitHub)" <gi...@apache.org>.
duncangrant commented on code in PR #184:
URL: https://github.com/apache/brooklyn-dist/pull/184#discussion_r1467410960


##########
karaf/features/src/main/resources/resources/NOTICE:
##########
@@ -146,9 +146,15 @@ Bundled dependencies:
     License name: MIT License
     Notice:       Copyright (c) 2011-2016 Twitter, Inc.
   
-  ch.qos.logback:1.2.3: 
+  ch.qos.logback:0.1.5: 

Review Comment:
   Looking at mvn dependency:tree
   [INFO] +- org.apache.karaf.features:framework:kar:4.3.8:compile
   [INFO] |  +- org.ops4j.pax.logging:pax-logging-logback:jar:2.0.18:compile
   [INFO] |  |  +- ch.qos.logback:logback-core:jar:1.2.9:compile
   [INFO] |  |  +- ch.qos.logback:logback-classic:jar:1.2.9:compile
   [INFO] |  |  +- ch.qos.logback.contrib:logback-jackson:jar:0.1.5:compile
   [INFO] |  |  +- ch.qos.logback.contrib:logback-json-core:jar:0.1.5:compile
   [INFO] |  |  \- ch.qos.logback.contrib:logback-json-classic:jar:0.1.5:compile
   
   It seems to be a different artifact with it's own versioning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org