You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2024/04/04 20:25:28 UTC
(camel) branch main updated: camel-smb: polish
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 31699bd91c8 camel-smb: polish
31699bd91c8 is described below
commit 31699bd91c84da65e1d5f4961396c61fe28be927
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Thu Apr 4 22:25:16 2024 +0200
camel-smb: polish
---
.../org/apache/camel/catalog/components/smb.json | 18 ++---
.../camel/component/smb/SmbEndpointUriFactory.java | 5 +-
.../org/apache/camel/component/smb/smb.json | 18 ++---
.../camel/component/smb/SmbConfiguration.java | 21 ++----
.../apache/camel/component/smb/SmbEndpoint.java | 3 +-
.../builder/endpoint/StaticEndpointBuilders.java | 4 +-
.../endpoint/dsl/SmbEndpointBuilderFactory.java | 76 +++++++++++-----------
.../apache/camel/kotlin/components/SmbUriDsl.kt | 16 ++---
8 files changed, 77 insertions(+), 84 deletions(-)
diff --git a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/smb.json b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/smb.json
index 28089712668..288cf4a4f10 100644
--- a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/smb.json
+++ b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/smb.json
@@ -29,15 +29,15 @@
"properties": {
"hostname": { "index": 0, "kind": "path", "displayName": "Hostname", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The share hostname or IP address" },
"port": { "index": 1, "kind": "path", "displayName": "Port", "group": "consumer", "label": "", "required": false, "type": "integer", "javaType": "int", "deprecated": false, "autowired": false, "secret": false, "defaultValue": 445, "description": "The share port number" },
- "shareName": { "index": 2, "kind": "path", "displayName": "Share Name", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": true, "description": "The name of the share to connect to." },
- "idempotentRepository": { "index": 3, "kind": "parameter", "displayName": "Idempotent Repository", "group": "consumer", "label": "advanced,consumer", "required": false, "type": "object", "javaType": "org.apache.camel.spi.IdempotentRepository", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "A pluggable repository org.apache.camel.spi.IdempotentRepo [...]
- "path": { "index": 4, "kind": "parameter", "displayName": "Path", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The path, within the share, to consume the files from" },
- "searchPattern": { "index": 5, "kind": "parameter", "displayName": "Search Pattern", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "*.txt", "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The search pattern used to list the files" },
- "sendEmptyMessageWhenIdle": { "index": 6, "kind": "parameter", "displayName": "Send Empty Message When Idle", "group": "consumer", "label": "consumer", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead." },
- "bridgeErrorHandler": { "index": 7, "kind": "parameter", "displayName": "Bridge Error Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions (if possible) occurred while the Camel consumer is trying to pickup incoming [...]
- "exceptionHandler": { "index": 8, "kind": "parameter", "displayName": "Exception Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.", "deprecated": false, "autowired": false, "secret": false, "description": "To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this option is not in use. By def [...]
- "exchangePattern": { "index": 9, "kind": "parameter", "displayName": "Exchange Pattern", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ], "deprecated": false, "autowired": false, "secret": false, "description": "Sets the exchange pattern when the consumer creates an exchange." },
- "pollStrategy": { "index": 10, "kind": "parameter", "displayName": "Poll Strategy", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.PollingConsumerPollStrategy", "deprecated": false, "autowired": false, "secret": false, "description": "A pluggable org.apache.camel.PollingConsumerPollingStrategy allowing you to provide your custom implementation to control error handling usually occurred during the po [...]
+ "shareName": { "index": 2, "kind": "path", "displayName": "Share Name", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The name of the share to connect to." },
+ "path": { "index": 3, "kind": "parameter", "displayName": "Path", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The path, within the share, to consume the files from" },
+ "searchPattern": { "index": 4, "kind": "parameter", "displayName": "Search Pattern", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "*.txt", "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The search pattern used to list the files" },
+ "sendEmptyMessageWhenIdle": { "index": 5, "kind": "parameter", "displayName": "Send Empty Message When Idle", "group": "consumer", "label": "consumer", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead." },
+ "bridgeErrorHandler": { "index": 6, "kind": "parameter", "displayName": "Bridge Error Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions (if possible) occurred while the Camel consumer is trying to pickup incoming [...]
+ "exceptionHandler": { "index": 7, "kind": "parameter", "displayName": "Exception Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.", "deprecated": false, "autowired": false, "secret": false, "description": "To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this option is not in use. By def [...]
+ "exchangePattern": { "index": 8, "kind": "parameter", "displayName": "Exchange Pattern", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ], "deprecated": false, "autowired": false, "secret": false, "description": "Sets the exchange pattern when the consumer creates an exchange." },
+ "pollStrategy": { "index": 9, "kind": "parameter", "displayName": "Poll Strategy", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.PollingConsumerPollStrategy", "deprecated": false, "autowired": false, "secret": false, "description": "A pluggable org.apache.camel.PollingConsumerPollingStrategy allowing you to provide your custom implementation to control error handling usually occurred during the pol [...]
+ "idempotentRepository": { "index": 10, "kind": "parameter", "displayName": "Idempotent Repository", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.IdempotentRepository", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "A pluggable repository org.apache.camel.spi.IdempotentRepository w [...]
"smbConfig": { "index": 11, "kind": "parameter", "displayName": "Smb Config", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "com.hierynomus.smbj.SmbConfig", "deprecated": false, "deprecationNote": "", "autowired": true, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "An optional SMB client configuration, can be used to configure client specific [...]
"smbIoBean": { "index": 12, "kind": "parameter", "displayName": "Smb Io Bean", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.component.smb.SmbIOBean", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "An optional SMB I\/O bean to use to setup the file access attributes when reading\/writi [...]
"backoffErrorThreshold": { "index": 13, "kind": "parameter", "displayName": "Backoff Error Threshold", "group": "scheduler", "label": "consumer,scheduler", "required": false, "type": "integer", "javaType": "int", "deprecated": false, "autowired": false, "secret": false, "description": "The number of subsequent error polls (failed due some error) that should happen before the backoffMultipler should kick-in." },
diff --git a/components/camel-smb/src/generated/java/org/apache/camel/component/smb/SmbEndpointUriFactory.java b/components/camel-smb/src/generated/java/org/apache/camel/component/smb/SmbEndpointUriFactory.java
index 579c569a29f..4d79905ad1a 100644
--- a/components/camel-smb/src/generated/java/org/apache/camel/component/smb/SmbEndpointUriFactory.java
+++ b/components/camel-smb/src/generated/java/org/apache/camel/component/smb/SmbEndpointUriFactory.java
@@ -53,9 +53,8 @@ public class SmbEndpointUriFactory extends org.apache.camel.support.component.En
props.add("useFixedDelay");
props.add("username");
PROPERTY_NAMES = Collections.unmodifiableSet(props);
- Set<String> secretProps = new HashSet<>(3);
+ Set<String> secretProps = new HashSet<>(2);
secretProps.add("password");
- secretProps.add("shareName");
secretProps.add("username");
SECRET_PROPERTY_NAMES = Collections.unmodifiableSet(secretProps);
Set<String> prefixes = new HashSet<>(1);
@@ -77,7 +76,7 @@ public class SmbEndpointUriFactory extends org.apache.camel.support.component.En
uri = buildPathParameter(syntax, uri, "hostname", null, true, copy);
uri = buildPathParameter(syntax, uri, "port", 445, false, copy);
- uri = buildPathParameter(syntax, uri, "shareName", null, false, copy);
+ uri = buildPathParameter(syntax, uri, "shareName", null, true, copy);
uri = buildQueryParameters(uri, copy, encode);
return uri;
}
diff --git a/components/camel-smb/src/generated/resources/META-INF/org/apache/camel/component/smb/smb.json b/components/camel-smb/src/generated/resources/META-INF/org/apache/camel/component/smb/smb.json
index 28089712668..288cf4a4f10 100644
--- a/components/camel-smb/src/generated/resources/META-INF/org/apache/camel/component/smb/smb.json
+++ b/components/camel-smb/src/generated/resources/META-INF/org/apache/camel/component/smb/smb.json
@@ -29,15 +29,15 @@
"properties": {
"hostname": { "index": 0, "kind": "path", "displayName": "Hostname", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The share hostname or IP address" },
"port": { "index": 1, "kind": "path", "displayName": "Port", "group": "consumer", "label": "", "required": false, "type": "integer", "javaType": "int", "deprecated": false, "autowired": false, "secret": false, "defaultValue": 445, "description": "The share port number" },
- "shareName": { "index": 2, "kind": "path", "displayName": "Share Name", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": true, "description": "The name of the share to connect to." },
- "idempotentRepository": { "index": 3, "kind": "parameter", "displayName": "Idempotent Repository", "group": "consumer", "label": "advanced,consumer", "required": false, "type": "object", "javaType": "org.apache.camel.spi.IdempotentRepository", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "A pluggable repository org.apache.camel.spi.IdempotentRepo [...]
- "path": { "index": 4, "kind": "parameter", "displayName": "Path", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The path, within the share, to consume the files from" },
- "searchPattern": { "index": 5, "kind": "parameter", "displayName": "Search Pattern", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "*.txt", "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The search pattern used to list the files" },
- "sendEmptyMessageWhenIdle": { "index": 6, "kind": "parameter", "displayName": "Send Empty Message When Idle", "group": "consumer", "label": "consumer", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead." },
- "bridgeErrorHandler": { "index": 7, "kind": "parameter", "displayName": "Bridge Error Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions (if possible) occurred while the Camel consumer is trying to pickup incoming [...]
- "exceptionHandler": { "index": 8, "kind": "parameter", "displayName": "Exception Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.", "deprecated": false, "autowired": false, "secret": false, "description": "To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this option is not in use. By def [...]
- "exchangePattern": { "index": 9, "kind": "parameter", "displayName": "Exchange Pattern", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ], "deprecated": false, "autowired": false, "secret": false, "description": "Sets the exchange pattern when the consumer creates an exchange." },
- "pollStrategy": { "index": 10, "kind": "parameter", "displayName": "Poll Strategy", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.PollingConsumerPollStrategy", "deprecated": false, "autowired": false, "secret": false, "description": "A pluggable org.apache.camel.PollingConsumerPollingStrategy allowing you to provide your custom implementation to control error handling usually occurred during the po [...]
+ "shareName": { "index": 2, "kind": "path", "displayName": "Share Name", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The name of the share to connect to." },
+ "path": { "index": 3, "kind": "parameter", "displayName": "Path", "group": "consumer", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The path, within the share, to consume the files from" },
+ "searchPattern": { "index": 4, "kind": "parameter", "displayName": "Search Pattern", "group": "consumer", "label": "", "required": false, "type": "string", "javaType": "java.lang.String", "deprecated": false, "autowired": false, "secret": false, "defaultValue": "*.txt", "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "The search pattern used to list the files" },
+ "sendEmptyMessageWhenIdle": { "index": 5, "kind": "parameter", "displayName": "Send Empty Message When Idle", "group": "consumer", "label": "consumer", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "If the polling consumer did not poll any files, you can enable this option to send an empty message (no body) instead." },
+ "bridgeErrorHandler": { "index": 6, "kind": "parameter", "displayName": "Bridge Error Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "boolean", "javaType": "boolean", "deprecated": false, "autowired": false, "secret": false, "defaultValue": false, "description": "Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions (if possible) occurred while the Camel consumer is trying to pickup incoming [...]
+ "exceptionHandler": { "index": 7, "kind": "parameter", "displayName": "Exception Handler", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.", "deprecated": false, "autowired": false, "secret": false, "description": "To let the consumer use a custom ExceptionHandler. Notice if the option bridgeErrorHandler is enabled then this option is not in use. By def [...]
+ "exchangePattern": { "index": 8, "kind": "parameter", "displayName": "Exchange Pattern", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ], "deprecated": false, "autowired": false, "secret": false, "description": "Sets the exchange pattern when the consumer creates an exchange." },
+ "pollStrategy": { "index": 9, "kind": "parameter", "displayName": "Poll Strategy", "group": "consumer (advanced)", "label": "consumer,advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.PollingConsumerPollStrategy", "deprecated": false, "autowired": false, "secret": false, "description": "A pluggable org.apache.camel.PollingConsumerPollingStrategy allowing you to provide your custom implementation to control error handling usually occurred during the pol [...]
+ "idempotentRepository": { "index": 10, "kind": "parameter", "displayName": "Idempotent Repository", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.spi.IdempotentRepository", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "A pluggable repository org.apache.camel.spi.IdempotentRepository w [...]
"smbConfig": { "index": 11, "kind": "parameter", "displayName": "Smb Config", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "com.hierynomus.smbj.SmbConfig", "deprecated": false, "deprecationNote": "", "autowired": true, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "An optional SMB client configuration, can be used to configure client specific [...]
"smbIoBean": { "index": 12, "kind": "parameter", "displayName": "Smb Io Bean", "group": "advanced", "label": "advanced", "required": false, "type": "object", "javaType": "org.apache.camel.component.smb.SmbIOBean", "deprecated": false, "autowired": false, "secret": false, "configurationClass": "org.apache.camel.component.smb.SmbConfiguration", "configurationField": "configuration", "description": "An optional SMB I\/O bean to use to setup the file access attributes when reading\/writi [...]
"backoffErrorThreshold": { "index": 13, "kind": "parameter", "displayName": "Backoff Error Threshold", "group": "scheduler", "label": "consumer,scheduler", "required": false, "type": "integer", "javaType": "int", "deprecated": false, "autowired": false, "secret": false, "description": "The number of subsequent error polls (failed due some error) that should happen before the backoffMultipler should kick-in." },
diff --git a/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConfiguration.java b/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConfiguration.java
index 08d283ad186..88d0ce867f6 100644
--- a/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConfiguration.java
+++ b/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConfiguration.java
@@ -28,31 +28,24 @@ public class SmbConfiguration {
protected static final int DEFAULT_IDEMPOTENT_CACHE_SIZE = 1000;
+ @Metadata(required = true)
+ @UriParam(description = "The path, within the share, to consume the files from")
+ private String path;
+ @UriParam(defaultValue = "*.txt", description = "The search pattern used to list the files")
+ private String searchPattern;
@UriParam(label = "security", description = "The username required to access the share", secret = true)
private String username;
-
@UriParam(label = "security", description = "The password to access the share", secret = true)
private String password;
-
@UriParam(label = "security", description = "The user domain")
private String domain;
-
- @Metadata(required = true)
- @UriParam(description = "The path, within the share, to consume the files from")
- private String path;
-
- @UriParam(defaultValue = "*.txt", description = "The search pattern used to list the files")
- private String searchPattern;
-
@UriParam(label = "advanced",
description = "An optional SMB I/O bean to use to setup the file access attributes when reading/writing a file")
private SmbIOBean smbIoBean = new SmbReadBean();
-
- @UriParam(label = "advanced,consumer", description = "A pluggable repository org.apache.camel.spi.IdempotentRepository "
- + "which by default use MemoryIdempotentRepository if none is specified.")
+ @UriParam(label = "advanced", description = "A pluggable repository org.apache.camel.spi.IdempotentRepository "
+ + "which by default use MemoryIdempotentRepository if none is specified.")
protected IdempotentRepository idempotentRepository
= MemoryIdempotentRepository.memoryIdempotentRepository(DEFAULT_IDEMPOTENT_CACHE_SIZE);
-
@Metadata(autowired = true)
@UriParam(label = "advanced",
description = "An optional SMB client configuration, can be used to configure client specific "
diff --git a/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbEndpoint.java b/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbEndpoint.java
index 8ed8b87f759..5fae5eca5fd 100644
--- a/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbEndpoint.java
+++ b/components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbEndpoint.java
@@ -39,7 +39,8 @@ public class SmbEndpoint extends ScheduledPollEndpoint {
private String hostname;
@UriPath(defaultValue = "445")
private int port;
- @UriPath(secret = true)
+ @UriPath
+ @Metadata(required = true)
private String shareName;
@UriParam
diff --git a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/StaticEndpointBuilders.java b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/StaticEndpointBuilders.java
index 9add93c2050..4a4e33f0289 100644
--- a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/StaticEndpointBuilders.java
+++ b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/StaticEndpointBuilders.java
@@ -13734,7 +13734,7 @@ public class StaticEndpointBuilders {
* The share port number
* Default value: 445
*
- * Path parameter: shareName
+ * Path parameter: shareName (required)
* The name of the share to connect to.
*
* @param path hostname:port/shareName
@@ -13761,7 +13761,7 @@ public class StaticEndpointBuilders {
* The share port number
* Default value: 445
*
- * Path parameter: shareName
+ * Path parameter: shareName (required)
* The name of the share to connect to.
*
* @param componentName to use a custom component name for the endpoint
diff --git a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SmbEndpointBuilderFactory.java b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SmbEndpointBuilderFactory.java
index 51fc374f974..e89490bf120 100644
--- a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SmbEndpointBuilderFactory.java
+++ b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SmbEndpointBuilderFactory.java
@@ -627,42 +627,6 @@ public interface SmbEndpointBuilderFactory {
default SmbEndpointBuilder basic() {
return (SmbEndpointBuilder) this;
}
- /**
- * A pluggable repository org.apache.camel.spi.IdempotentRepository
- * which by default use MemoryIdempotentRepository if none is specified.
- *
- * The option is a:
- * <code>org.apache.camel.spi.IdempotentRepository</code>
- * type.
- *
- * Group: consumer
- *
- * @param idempotentRepository the value to set
- * @return the dsl builder
- */
- default AdvancedSmbEndpointBuilder idempotentRepository(
- org.apache.camel.spi.IdempotentRepository idempotentRepository) {
- doSetProperty("idempotentRepository", idempotentRepository);
- return this;
- }
- /**
- * A pluggable repository org.apache.camel.spi.IdempotentRepository
- * which by default use MemoryIdempotentRepository if none is specified.
- *
- * The option will be converted to a
- * <code>org.apache.camel.spi.IdempotentRepository</code>
- * type.
- *
- * Group: consumer
- *
- * @param idempotentRepository the value to set
- * @return the dsl builder
- */
- default AdvancedSmbEndpointBuilder idempotentRepository(
- String idempotentRepository) {
- doSetProperty("idempotentRepository", idempotentRepository);
- return this;
- }
/**
* Allows for bridging the consumer to the Camel routing Error Handler,
* which mean any exceptions (if possible) occurred while the Camel
@@ -825,6 +789,42 @@ public interface SmbEndpointBuilderFactory {
doSetProperty("pollStrategy", pollStrategy);
return this;
}
+ /**
+ * A pluggable repository org.apache.camel.spi.IdempotentRepository
+ * which by default use MemoryIdempotentRepository if none is specified.
+ *
+ * The option is a:
+ * <code>org.apache.camel.spi.IdempotentRepository</code>
+ * type.
+ *
+ * Group: advanced
+ *
+ * @param idempotentRepository the value to set
+ * @return the dsl builder
+ */
+ default AdvancedSmbEndpointBuilder idempotentRepository(
+ org.apache.camel.spi.IdempotentRepository idempotentRepository) {
+ doSetProperty("idempotentRepository", idempotentRepository);
+ return this;
+ }
+ /**
+ * A pluggable repository org.apache.camel.spi.IdempotentRepository
+ * which by default use MemoryIdempotentRepository if none is specified.
+ *
+ * The option will be converted to a
+ * <code>org.apache.camel.spi.IdempotentRepository</code>
+ * type.
+ *
+ * Group: advanced
+ *
+ * @param idempotentRepository the value to set
+ * @return the dsl builder
+ */
+ default AdvancedSmbEndpointBuilder idempotentRepository(
+ String idempotentRepository) {
+ doSetProperty("idempotentRepository", idempotentRepository);
+ return this;
+ }
/**
* An optional SMB client configuration, can be used to configure client
* specific configurations, like timeouts.
@@ -913,7 +913,7 @@ public interface SmbEndpointBuilderFactory {
* The share port number
* Default value: 445
*
- * Path parameter: shareName
+ * Path parameter: shareName (required)
* The name of the share to connect to.
*
* @param path hostname:port/shareName
@@ -939,7 +939,7 @@ public interface SmbEndpointBuilderFactory {
* The share port number
* Default value: 445
*
- * Path parameter: shareName
+ * Path parameter: shareName (required)
* The name of the share to connect to.
*
* @param componentName to use a custom component name for the endpoint
diff --git a/dsl/camel-kotlin-api/src/generated/kotlin/org/apache/camel/kotlin/components/SmbUriDsl.kt b/dsl/camel-kotlin-api/src/generated/kotlin/org/apache/camel/kotlin/components/SmbUriDsl.kt
index 95ccc197484..0b76b3e420d 100644
--- a/dsl/camel-kotlin-api/src/generated/kotlin/org/apache/camel/kotlin/components/SmbUriDsl.kt
+++ b/dsl/camel-kotlin-api/src/generated/kotlin/org/apache/camel/kotlin/components/SmbUriDsl.kt
@@ -79,14 +79,6 @@ public class SmbUriDsl(
it.url("$hostname:$port/$shareName")
}
- /**
- * A pluggable repository org.apache.camel.spi.IdempotentRepository which by default use
- * MemoryIdempotentRepository if none is specified.
- */
- public fun idempotentRepository(idempotentRepository: String) {
- it.property("idempotentRepository", idempotentRepository)
- }
-
/**
* The path, within the share, to consume the files from
*/
@@ -172,6 +164,14 @@ public class SmbUriDsl(
it.property("pollStrategy", pollStrategy)
}
+ /**
+ * A pluggable repository org.apache.camel.spi.IdempotentRepository which by default use
+ * MemoryIdempotentRepository if none is specified.
+ */
+ public fun idempotentRepository(idempotentRepository: String) {
+ it.property("idempotentRepository", idempotentRepository)
+ }
+
/**
* An optional SMB client configuration, can be used to configure client specific configurations,
* like timeouts