You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lovepoem (GitHub)" <gi...@apache.org> on 2019/01/22 03:55:59 UTC
[GitHub] [incubator-dubbo] lovepoem opened pull request #3300: add
openjdk to travis
## What is the purpose of the change
add openjdk to travis
## Brief changelog
.travs.yml
## Verifying this change
CI success
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem commented on issue #3300: add
openjdk to travis
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> Why do we need both? I think we only need to choose between oraclejdk and openjdk.
> I have the same question.
It’s because Oracle jdku192 above will not for free to enterprises
I think other kinf of jdk will be selected，e.g.: openjdk
please see the notice from Oracle jdk
English version : https://java.com/en/download/release_notice.jsp
中文地址： https://java.com/zh_CN/download/release_notice.jsp
some price list
https://www.oracle.com/assets/java-se-subscription-pricelist-5028356.pdf
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3300: add
openjdk to travis
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
> > Yes, I agree to use openjdk, but why should we keep oraclejdk?
>
> Or should I send a mail to dev@ list for discussion?
I've raised a discussion before, search for `CI failure for Java 11 - switching to openjdk?` I think we can discuss there, or you can discuss by forwarding this message to dev@ mailing list.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lixiaojiee commented on pull request
#3300: add openjdk to travis
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
I have the same question.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] tswstarplanet commented on issue #3300:
add openjdk to travis
Posted by "tswstarplanet (GitHub)" <gi...@apache.org>.
I think if Dubbo can use Oracle JDK freely, we can contains it in travis. Because companies using Oracle JDK may use Dubbo too. We should consider those users.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem commented on issue #3300: add
openjdk to travis
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> Why do we need both? I think we only need to choose between oraclejdk and openjdk.
> I have the same question.
It’s because Oracle jdku192 above will not for free to enterprises
I think other kindf of jdk will be selected，e.g.: openjdk
please see the notice from Oracle jdk
English version : https://java.com/en/download/release_notice.jsp
中文地址： https://java.com/zh_CN/download/release_notice.jsp
some price list
https://www.oracle.com/assets/java-se-subscription-pricelist-5028356.pdf
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem commented on issue #3300: add
openjdk to travis
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> Why do we need both? I think we only need to choose between oraclejdk and openjdk.
> I have the same question.
It’s because Oracle jdku192 above will not for free to enterprises
I think other kinf of jdk will be selected，e.g.: openjdk
please see the notice from Oracle jdk
English version : https://java.com/en/download/release_notice.jsp
中文地址： https://java.com/zh_CN/download/release_notice.jsp
some price list
https://www.oracle.com/assets/java-se-subscription-pricelist-5028356.pdf
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3300: add
openjdk to travis
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=h1) Report
> Merging [#3300](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e07038b00e057bb3cd6989252534b581039916f9?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3300 +/- ##
==========================================
+ Coverage 63.79% 63.9% +0.1%
Complexity 75 75
==========================================
Files 661 661
Lines 28624 28624
Branches 4826 4826
==========================================
+ Hits 18262 18291 +29
+ Misses 8148 8126 -22
+ Partials 2214 2207 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.45% <0%> (-0.37%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `62.16% <0%> (+0.9%)` | `0% <0%> (ø)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.92% <0%> (+1.15%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `66.66% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `72.97% <0%> (+2.02%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `67.39% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `81.25% <0%> (+6.25%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `73.21% <0%> (+8.92%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `56.81% <0%> (+11.36%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3300/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=footer). Last update [e07038b...7af92ef](https://codecov.io/gh/apache/incubator-dubbo/pull/3300?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3300:
add openjdk to travis
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Why do we need both? I think we only need to choose between oraclejdk and openjdk.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem commented on issue #3300: add
openjdk to travis
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> Yes, I agree to use openjdk, but why should we keep oraclejdk?
Or should I send a mail to dev@ list for discussion?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang closed pull request #3300:
add openjdk to travis
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ pull request closed by zonghaishang ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3300: add
openjdk to travis
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Yes, I agree to use openjdk, but why should we keep oraclejdk?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3300 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org