You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2019/02/25 18:17:30 UTC
[incubator-pinot] branch fix-listFiles-in-PinotFS updated: Address
PR comments
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch fix-listFiles-in-PinotFS
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/fix-listFiles-in-PinotFS by this push:
new 017219c Address PR comments
017219c is described below
commit 017219cf499779b4321c8f3e2bf283afc9cd571e
Author: jackjlli <jl...@linkedin.com>
AuthorDate: Mon Feb 25 10:17:12 2019 -0800
Address PR comments
---
.../pinot/controller/api/resources/LLCSegmentCompletionHandlers.java | 1 +
.../controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
index e7312e7..0d5de21 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
@@ -306,6 +306,7 @@ public class LLCSegmentCompletionHandlers {
if (isSplitCommit) {
// We only clean up tmp segment file under table dir, so don't create any sub-dir under table dir.
// See PinotLLCRealtimeSegmentManager.commitSegmentFile().
+ // TODO: move tmp file logic into SegmentCompletionUtils.
String uniqueSegmentFileName = SegmentCompletionUtils.generateSegmentFileName(segmentName);
segmentFileURI =
ControllerConf.getUriFromPath(StringUtil.join("/", tableDirURI.toString(), uniqueSegmentFileName));
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
index f5e05b9..6b32400 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
@@ -394,7 +394,7 @@ public class PinotLLCRealtimeSegmentManager {
// Cleans up tmp segment files under table dir.
// We only clean up tmp segment files in table level dir, so there's no need to list recursively.
// See LLCSegmentCompletionHandlers.uploadSegment().
- // See LLCSegmentCompletionHandlers.uploadSegment().
+ // TODO: move tmp file logic into SegmentCompletionUtils.
try {
for (String uri : pinotFS.listFiles(tableDirURI, false)) {
if (uri.contains(SegmentCompletionUtils.getSegmentNamePrefix(segmentName))) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org