You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Divij Vaidya (Jira)" <ji...@apache.org> on 2022/05/30 08:53:00 UTC

[jira] [Created] (KAFKA-13947) Format strings appropriately for their argument types

Divij Vaidya created KAFKA-13947:
------------------------------------

             Summary: Format strings appropriately for their argument types
                 Key: KAFKA-13947
                 URL: https://issues.apache.org/jira/browse/KAFKA-13947
             Project: Kafka
          Issue Type: Bug
    Affects Versions: 3.2.0
            Reporter: Divij Vaidya


At various places in the code base, String.format() uses '%s' to format long or integer. This is a potential locale-sensitive handling issue.

The fix should be made at the following places:

1. [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/compress/KafkaLZ4BlockInputStream.java#L176]
2. [https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/QuorumController.java#L473]
3. [https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java#L1264]
4. [https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java#L94]
5. https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java#L192
6. [https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java#L120]
7. [https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/LeaderState.java#L356]
8. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java#L52

Note that the files listed above have more such lines where %s is incorrectly used.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)