[GitHub] [calcite] MasseGuillaume commented on a diff in pull request #3141: [CALCITE-5624] Add support to parse array function call with Spark

["MasseGuillaume (via GitHub)" <gi...@apache.org>]

MasseGuillaume commented on code in PR #3141:
URL: https://github.com/apache/calcite/pull/3141#discussion_r1157607072


##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -439,4 +446,13 @@ public enum SqlConformanceEnum implements SqlConformance {
       return false;
     }
   }
+
+  @Override public boolean allowArrayFunction() {
+    switch (this) {

Review Comment:
   I'm following the same coding style as the rest of the file.
   
   https://github.com/apache/calcite/blob/8d502cf421441a791db38ff8c87abc47fa45dd74/core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java#L441-L448
   
   if we want to append to the list, the git diff will look better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org