You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:43:21 UTC
[GitHub] [cloudstack] ServiceTo opened a new pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
ServiceTo opened a new pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109
## Description
`/opt/cloud/bin/setup_heartbeat_sr.sh` line 75 tests for “XenServer release 7.” in `/etc/redhat-release` which contains “XCP-ng release 8.0.0 (xenenterprise)” in my case so the `lvcreate` statement doesn’t contain the required options
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #3281
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
Adding an iSCSI endpoint now succeeds with XCP-ng 8.0.0. I've left the previous XenServer logic alone just added the XCP-ng test case into the else block. This could definitely be fine tuned by someone who's more intimate with these scripts but I just wanted the issue fixed without interfering in the logic.
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-640336479
Packaging result: ✖centos7 ✖debian. JID-1304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-640320561
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-638555307
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641251366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-638555574
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-640320349
@shwstppr can you review this?
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641315181
@blueorangutan test centos7 xenserver-71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641315181
@blueorangutan test centos7 xenserver-71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-638574095
Packaging result: ✖centos7 ✔debian. JID-1276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-642597452
Trillian env runs using NFS, this case won't get tested. Travis passed https://travis-ci.org/github/apache/cloudstack/builds/696396726 I'll merge based on this and that the author has provided information how this was tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-642597452
Trillian env runs using NFS, this case won't get tested by default. Travis passed https://travis-ci.org/github/apache/cloudstack/builds/696396726 I'll merge based on this and that the author has provided information how this was tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641258592
Packaging OK!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4109:
URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641315986
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org