You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/14 00:55:23 UTC

[GitHub] [samza] prateekm commented on a change in pull request #1416: SAMZA-2581: Fix Samza Histogram update to update percentile Gauge values

prateekm commented on a change in pull request #1416:
URL: https://github.com/apache/samza/pull/1416#discussion_r470346356



##########
File path: samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
##########
@@ -53,6 +53,7 @@ public SamzaHistogram(MetricsRegistry registry, String group, String name, List<
 
   public void update(long value) {
     histogram.update(value);
+    percentiles.forEach(x -> updateGaugeValues(x));

Review comment:
       Looks like the gauge value is already updated when it is reported (line 76 Gauge#visit). Why do we need to update them on every new datapoint?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org