You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2023/05/16 16:05:27 UTC

[GitHub] [hudi] Zouxxyy opened a new pull request, #8731: [minor] Change scalastyle ReturnChecker lever

Zouxxyy opened a new pull request, #8731:
URL: https://github.com/apache/hudi/pull/8731

   ### Change Logs
   
   Change scalastyle ReturnChecker lever to error
   
   ### Impact
   
   Change scalastyle ReturnChecker lever to error
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8731:
URL: https://github.com/apache/hudi/pull/8731#issuecomment-1550041433

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17131",
       "triggerID" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6aa19abb165a6f7995275ad6e990ffbe07bb8be0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17131) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8731:
URL: https://github.com/apache/hudi/pull/8731#issuecomment-1550492091

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17131",
       "triggerID" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6aa19abb165a6f7995275ad6e990ffbe07bb8be0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17131) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8731:
URL: https://github.com/apache/hudi/pull/8731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8731:
URL: https://github.com/apache/hudi/pull/8731#issuecomment-1550027279

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6aa19abb165a6f7995275ad6e990ffbe07bb8be0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6aa19abb165a6f7995275ad6e990ffbe07bb8be0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8731:
URL: https://github.com/apache/hudi/pull/8731#issuecomment-1550580545

   @Zouxxyy Thanks for the contribution, can you elaborate what the effect of the change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] Zouxxyy commented on pull request #8731: [MINOR] Change scalastyle ReturnChecker lever

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #8731:
URL: https://github.com/apache/hudi/pull/8731#issuecomment-1550597448

   @danny0405 Return is not recommended in scala, and only a few of them are used in hudi now. We can turn on this detection to make the code more standardized


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org