You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/07/14 17:50:56 UTC
[pinot] branch master updated: Allow offloading multiple segments from same table in parallel (#11107)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 135fa4322e Allow offloading multiple segments from same table in parallel (#11107)
135fa4322e is described below
commit 135fa4322e77c43fe0096ea3006aade4407760c9
Author: Xiaotian (Jackie) Jiang <17...@users.noreply.github.com>
AuthorDate: Fri Jul 14 10:50:50 2023 -0700
Allow offloading multiple segments from same table in parallel (#11107)
---
.../server/starter/helix/HelixInstanceDataManager.java | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
index fea900201b..f01d13ea94 100644
--- a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
+++ b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
@@ -283,11 +283,14 @@ public class HelixInstanceDataManager implements InstanceDataManager {
@Override
public void offloadSegment(String tableNameWithType, String segmentName) {
LOGGER.info("Removing segment: {} from table: {}", segmentName, tableNameWithType);
- _tableDataManagerMap.computeIfPresent(tableNameWithType, (k, v) -> {
- v.removeSegment(segmentName);
- LOGGER.info("Removed segment: {} from table: {}", segmentName, k);
- return v;
- });
+ TableDataManager tableDataManager = _tableDataManagerMap.get(tableNameWithType);
+ if (tableDataManager != null) {
+ tableDataManager.removeSegment(segmentName);
+ LOGGER.info("Removed segment: {} from table: {}", segmentName, tableNameWithType);
+ } else {
+ LOGGER.warn("Failed to find data manager for table: {}, skipping removing segment: {}", tableNameWithType,
+ segmentName);
+ }
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org